From: Olof Johansson <olof@lixom.net>
To: Boris BREZILLON <brezillonboris@gmail.com>
Cc: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>,
Nicolas Ferre <nicolas.ferre@atmel.com>,
Arnd Bergmann <arnd@arndb.de>,
linux-arm-kernel@lists.infradead.org, arm@kernel.org,
linux-kernel@vger.kernel.org,
Boris BREZILLON <b.brezillon.dev@gmail.com>
Subject: Re: [PATCH] net: macb: set interface name based on DT aliases
Date: Mon, 5 May 2014 13:40:22 -0700 [thread overview]
Message-ID: <20140505204022.GA27961@quad.lixom.net> (raw)
In-Reply-To: <1394620196-6295-1-git-send-email-b.brezillon.dev@gmail.com>
On Wed, Mar 12, 2014 at 11:29:56AM +0100, Boris BREZILLON wrote:
> Use aliases to set the interface name (ethX) instead of automatic
> assignement.
>
> Signed-off-by: Boris BREZILLON <b.brezillon.dev@gmail.com>
> ---
>
> Hello Nicolas, Jean-Christophe,
>
> This is an example on how we could set the ethernet interface id based on DT
> aliases.
> As you can see this patch is not properly separated.
>
> I'm still not happy with this approach for several reasons:
> 1) If another ethernet iface has already been registered with the same id the
> net dev registration will fail.
> 2) We bypass the ethernet macros/functions and directly use the net device
> functions which IMHO is not future proof.
[Sorry for the late reply, going through old backlog of unread email]
Looks like this should live in networking core instead of in the driver, it's
how we handle it in other subsystems.
I don't know what DaveM's opinions on that is though.
-Olof
next prev parent reply other threads:[~2014-05-05 20:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-12 10:29 Boris BREZILLON
2014-05-05 20:40 ` Olof Johansson [this message]
2014-05-06 15:17 ` Boris BREZILLON
-- strict thread matches above, loose matches on Subject: below --
2014-03-12 7:59 [PATCH for 3.14] ARM: at91: fix network interface ordering for sama5d36 Nicolas Ferre
2014-03-12 10:30 ` [PATCH] net: macb: set interface name based on DT aliases Boris BREZILLON
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140505204022.GA27961@quad.lixom.net \
--to=olof@lixom.net \
--cc=arm@kernel.org \
--cc=arnd@arndb.de \
--cc=b.brezillon.dev@gmail.com \
--cc=brezillonboris@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nicolas.ferre@atmel.com \
--cc=plagnioj@jcrosoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®