From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756441AbaEEVHJ (ORCPT ); Mon, 5 May 2014 17:07:09 -0400 Received: from out2-smtp.messagingengine.com ([66.111.4.26]:55153 "EHLO out2-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756087AbaEEVHG (ORCPT ); Mon, 5 May 2014 17:07:06 -0400 X-Sasl-enc: 1eLjRu2rbQEuyacCg/P4wC9cQl8hOXSTTlfKiDtc5BCG 1399324025 Date: Mon, 5 May 2014 14:10:10 -0700 From: Greg KH To: =?iso-8859-1?Q?Cl=E9ment?= Calmels Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: vt6655: correct coding style issue Message-ID: <20140505211010.GB27503@kroah.com> References: <1399233129-13436-1-git-send-email-clement.calmels@free.fr> <20140504212658.GA28438@kroah.com> <20140505211603.4e3b6f42@gromit> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20140505211603.4e3b6f42@gromit> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, May 05, 2014 at 09:16:03PM +0200, Clément Calmels wrote: > On Sun, 4 May 2014 17:26:58 -0400 > Greg KH wrote: > > > On Sun, May 04, 2014 at 09:52:09PM +0200, Clément Calmels wrote: > > > Remove C99 comment and rewrite lines over 80 characters. > > > Warnings and error found by checkpatch.pl script. > > > > > > Signed-off-by: Clément Calmels > > > --- > > > drivers/staging/vt6655/tmacro.h | 13 +++++++++---- > > > 1 file changed, 9 insertions(+), 4 deletions(-) > > > > > > diff --git a/drivers/staging/vt6655/tmacro.h > > > b/drivers/staging/vt6655/tmacro.h index 59c6e72..264c6ed 100644 > > > --- a/drivers/staging/vt6655/tmacro.h > > > +++ b/drivers/staging/vt6655/tmacro.h > > > @@ -44,17 +44,22 @@ > > > #define LOWORD(d) ((unsigned short)(d)) > > > #endif > > > #if !defined(HIWORD) > > > -#define HIWORD(d) ((unsigned short)((((unsigned > > > long)(d)) >> 16) & 0xFFFF)) +#define > > > HIWORD(d) \ > > > + ((unsigned short)((((unsigned long)(d)) >> 16) & 0xFFFF)) > > > #endif > > > > > > #define LODWORD(q) ((q).u.dwLowDword) > > > #define HIDWORD(q) ((q).u.dwHighDword) > > > > > > #if !defined(MAKEWORD) > > > -#define MAKEWORD(lb, hb) ((unsigned short)(((unsigned > > > char)(lb)) | (((unsigned short)((unsigned char)(hb))) << 8))) > > > +#define MAKEWORD(lb, hb)\ > > > + ((unsigned short)(((unsigned > > > char)(lb)) \ > > > + | (((unsigned short)((unsigned > > > char)(hb))) << 8))) #endif > > > #if !defined(MAKEDWORD) > > > -#define MAKEDWORD(lw, hw) ((unsigned long)(((unsigned > > > short)(lw)) | (((unsigned long)((unsigned short)(hw))) << 16))) > > > +#define MAKEDWORD(lw, hw)\ > > > + ((unsigned long)(((unsigned > > > short)(lw)) \ > > > + | (((unsigned long)((unsigned > > > short)(hw))) << 16))) #endif > > > > > > -#endif // __TMACRO_H__ > > > +#endif /* __TMACRO_H__ */ > > > > Why not just switch to use the built-in macros the kernel provides for > > this? > > > > greg k-h > > Are you talking about changing types (unsigned char => u8) as used > there: > http://lxr.free-electrons.com/source/sound/isa/msnd/msnd.h#L182 or > there: > http://lxr.free-electrons.com/source/include/acpi/actypes.h#L481 ? No, how about get_unaligned_le16() and put_unaligned_le16()? Don't those do what you want here? thanks, greg k-h