From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751662AbaEGW0A (ORCPT ); Wed, 7 May 2014 18:26:00 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:58019 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750966AbaEGWZ6 (ORCPT ); Wed, 7 May 2014 18:25:58 -0400 Date: Wed, 7 May 2014 15:25:57 -0700 From: Andrew Morton To: Fabian Frederick Cc: linux-kernel , Rusty Russell Subject: Re: [PATCH 1/1] KERNEL: add __attribute__ in c file Message-Id: <20140507152557.7bf8998f900c5f2054295e68@linux-foundation.org> In-Reply-To: <20140507223339.3dccf63d066edbcac207e6f3@skynet.be> References: <20140507223339.3dccf63d066edbcac207e6f3@skynet.be> X-Mailer: Sylpheed 3.2.0beta5 (GTK+ 2.24.10; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 7 May 2014 22:33:39 +0200 Fabian Frederick wrote: > This patch fixes a sparse warning about noreturn attribute only > featuring in module.h > > kernel/module.c:212:6: error: symbol '__module_put_and_exit' redeclared with > different type (originally declared at include/linux/module.h:449)- > different modifiers > > ... > > --- a/include/linux/module.h > +++ b/include/linux/module.h > @@ -446,8 +446,8 @@ int module_kallsyms_on_each_symbol(int (*fn)(void *, const char *, > struct module *, unsigned long), > void *data); > > -extern void __module_put_and_exit(struct module *mod, long code) > - __attribute__((noreturn)); > +extern void __attribute__((noreturn)) __module_put_and_exit(struct module *mod, > + long code); > #define module_put_and_exit(code) __module_put_and_exit(THIS_MODULE, code) > > #ifdef CONFIG_MODULE_UNLOAD > diff --git a/kernel/module.c b/kernel/module.c > index 079c461..7d78872 100644 > --- a/kernel/module.c > +++ b/kernel/module.c > @@ -209,7 +209,8 @@ static inline void add_taint_module(struct module *mod, unsigned flag, > * A thread that wants to hold a reference to a module only while it > * is running can call this to safely exit. nfsd and lockd use this. > */ > -void __module_put_and_exit(struct module *mod, long code) > +void __attribute__((noreturn)) __module_put_and_exit(struct module *mod, > + long code) > { Can we use __noreturn here?