From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933074AbaEGQmd (ORCPT ); Wed, 7 May 2014 12:42:33 -0400 Received: from lxorguk.ukuu.org.uk ([81.2.110.251]:45443 "EHLO lxorguk.ukuu.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932223AbaEGQmb (ORCPT ); Wed, 7 May 2014 12:42:31 -0400 Date: Wed, 7 May 2014 17:41:51 +0100 From: One Thousand Gnomes To: Will Deacon Cc: Andrew Morton , Jan Kara , "mm-commits@vger.kernel.org" , "peterz@infradead.org" , "kay@vrfy.org" , LKML Subject: Re: + printk-print-initial-logbuf-contents-before-re-enabling-interrupts.patch added to -mm tree Message-ID: <20140507174151.3c28f15a@alan.etchedpixels.co.uk> In-Reply-To: <20140507095850.GC18456@arm.com> References: <53640c8c.5++0zeO0pmfqKMwm%akpm@linux-foundation.org> <20140502224651.GG23636@quack.suse.cz> <20140506120648.GA30234@arm.com> <20140506122958.GG9291@quack.suse.cz> <20140506131234.GD30234@arm.com> <20140506150553.a12959fd71d83eddcb4b325d@linux-foundation.org> <20140507095850.GC18456@arm.com> Organization: Intel Corporation X-Mailer: Claws Mail 3.8.1 (GTK+ 2.24.20; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > Possibly, but I fear we'd incur the wrath of Alan after reading that other > thread. Having a CONFIG_ option or similar to control the amount of printing > we do is very similar to the command-line option Jan proposed in his series. I've nothing against a configuration option, and having a printk that queued most stuff to the serial IRQ handler on overflow and a boot option of printk=synchronous for debug work would be awesome in my book. Many end production boxes don't give a toss about losing the odd bit of data they just need to shift the logs somewhere for filing. All these "clever" approaches just seem to me to be ever more convoluted attempts to fail to deal with the simple reality that if you put more down the sewage pipe than fits it has to overflow somewhere. Our tty drivers have a fifo, our tty drivers have an IRQ driven write operation. It seems silly to be adding magic to solve the problem rather than just using it (and in turn getting a ton of other consoles for free, and being able to take GregKH's current usb console hack out) Alan