From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751634AbaEGRLM (ORCPT ); Wed, 7 May 2014 13:11:12 -0400 Received: from lxorguk.ukuu.org.uk ([81.2.110.251]:45510 "EHLO lxorguk.ukuu.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750810AbaEGRLI (ORCPT ); Wed, 7 May 2014 13:11:08 -0400 Date: Wed, 7 May 2014 18:10:42 +0100 From: One Thousand Gnomes To: "H. Peter Anvin" Cc: "David E. Box" , tglx@linutronix.de, mingo@redhat.com, x86@kernel.org, rafael.j.wysocki@intel.com, linux-kernel@vger.kernel.org, kristen.c.accardi@intel.com, jacob.jun.pan@linux.intel.com Subject: Re: [PATCH v3] x86/iosf: Make IOSF driver modular and usable by more drivers Message-ID: <20140507181042.7b4dff18@alan.etchedpixels.co.uk> In-Reply-To: <536A67B8.1080805@zytor.com> References: <1398810789-2301-1-git-send-email-david.e.box@linux.intel.com> <1399052199-8703-1-git-send-email-david.e.box@linux.intel.com> <20140507174801.20fc0d67@alan.etchedpixels.co.uk> <536A67B8.1080805@zytor.com> Organization: Intel Corporation X-Mailer: Claws Mail 3.8.1 (GTK+ 2.24.20; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 07 May 2014 10:04:56 -0700 "H. Peter Anvin" wrote: > On 05/07/2014 09:48 AM, One Thousand Gnomes wrote: > > On Fri, 2 May 2014 10:36:39 -0700 > >> +bool iosf_mbi_available(void) > >> +{ > >> + return mbi_pdev; > >> +} > >> +EXPORT_SYMBOL(iosf_mbi_available); > > > > Probably worth a follow up patch that comments this so the assumption > > that iosf can never be unloaded or hot-unplugged is clear. > > > > When you say unloaded you mean the module or the hardware? Both. Currently the hardware isn't removable (but could be virtually removed by playing with unplugging) and the module can't be unloaded so the assumption is fine. Alan