mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Cc: linux-kernel@vger.kernel.org,
	Sasha Levin <sasha.levin@oracle.com>,
	Oleg Nesterov <oleg@redhat.com>, Dave Jones <davej@redhat.com>
Subject: Re: [PATCH] Fix: tracepoint: use after rcu free
Date: Thu, 8 May 2014 09:15:29 -0400	[thread overview]
Message-ID: <20140508091529.08b68cf4@gandalf.local.home> (raw)
In-Reply-To: <55466295.13096.1399554505453.JavaMail.zimbra@efficios.com>

On Thu, 8 May 2014 13:08:25 +0000 (UTC)
Mathieu Desnoyers <mathieu.desnoyers@efficios.com> wrote:

> > 
> > We can also include a (even though it's redundant)
> > 
> >  Fixes: de7b2973903c "tracepoint: Use struct pointer instead of name hash for
> >  reg/unreg tracepoints"
> 
> Thanks for the pointers, I'll keep those in mind for my next patches.

Oh, one more thing I keep forgetting to mention to you. Your subject
lines :-)

I converted it to be:

 tracepoint: Fix use of tracepoint funcs after rcu free

only the subsystem tag should be used. Not a "Fix" tag. But the "Fix"
may be used in the subject itself. Also, I've been told that Linus
prefers to have the subject written more like a sentence and the first
character capitalized.

-- Steve

  reply	other threads:[~2014-05-08 13:15 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-08 11:47 Mathieu Desnoyers
2014-05-08 13:05 ` Steven Rostedt
2014-05-08 13:08   ` Mathieu Desnoyers
2014-05-08 13:15     ` Steven Rostedt [this message]
2014-05-08 13:20       ` Mathieu Desnoyers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140508091529.08b68cf4@gandalf.local.home \
    --to=rostedt@goodmis.org \
    --cc=davej@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mathieu.desnoyers@efficios.com \
    --cc=oleg@redhat.com \
    --cc=sasha.levin@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®