From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Doug Anderson <dianders@chromium.org>
Cc: Nicolas Pitre <nicolas.pitre@linaro.org>,
Viresh Kumar <viresh.kumar@linaro.org>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Will Deacon <will.deacon@arm.com>,
John Stultz <john.stultz@linaro.org>,
David Riley <davidriley@chromium.org>,
"olof@lixom.net" <olof@lixom.net>,
Sonny Rao <sonnyrao@chromium.org>,
Richard Zhao <richard.zhao@linaro.org>,
Santosh Shilimkar <santosh.shilimkar@ti.com>,
Shawn Guo <shawn.guo@linaro.org>,
Stephen Boyd <sboyd@codeaurora.org>,
Marc Zyngier <marc.zyngier@arm.com>,
Stephen Warren <swarren@nvidia.com>,
Paul Gortmaker <paul.gortmaker@windriver.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ARM: Don't ever downscale loops_per_jiffy in SMP systems
Date: Thu, 8 May 2014 21:55:56 +0100 [thread overview]
Message-ID: <20140508205556.GJ3693@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <CAD=FV=X4h0nfO7a10NXe+d76xj5ttBJx=q1pAvW4aPzrc22BoQ@mail.gmail.com>
On Thu, May 08, 2014 at 11:06:24AM -0700, Doug Anderson wrote:
> I guess I would say that my patch is unhacking the this code. The
> code after my patch is simpler. I would perhaps argue that (ec971ea
> ARM: add cpufreq transiton notifier to adjust loops_per_jiffy for smp)
> should never have landed to begin with.
That depends on your point of view. As I've already pointed out through
the examples of why udelay() is inaccurate, for driver authors, they
should assume that udelay() just gives you an "approximate" delay and
it has no accuracy.
When you start from that point, rather than (as you seem to be) believing
that it has some kind of accuracy, then the implementation of scaling the
loops_per_jiffy is entirely reasonable - it's a best effort implementation.
Again, just use a timer for your udelay() implementation.
--
FTTC broadband for 0.8mile line: now at 9.7Mbps down 460kbps up... slowly
improving, and getting towards what was expected from it.
next prev parent reply other threads:[~2014-05-08 20:57 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-07 23:23 Doug Anderson
2014-05-08 10:41 ` Viresh Kumar
2014-05-08 15:25 ` Doug Anderson
2014-05-08 16:04 ` Nicolas Pitre
2014-05-08 16:41 ` Doug Anderson
2014-05-08 17:43 ` Nicolas Pitre
2014-05-08 18:06 ` Doug Anderson
2014-05-08 19:59 ` Nicolas Pitre
2014-05-08 20:55 ` Russell King - ARM Linux [this message]
2014-05-09 0:02 ` Doug Anderson
2014-05-09 0:23 ` Russell King - ARM Linux
2014-05-09 4:41 ` Doug Anderson
2014-05-08 19:22 ` Russell King - ARM Linux
2014-05-08 20:12 ` Nicolas Pitre
2014-05-08 20:39 ` John Stultz
2014-05-08 20:52 ` Russell King - ARM Linux
2014-05-09 1:37 ` Nicolas Pitre
2014-05-09 4:43 ` Doug Anderson
2014-05-09 9:18 ` [PATCH] ARM: Don't ever downscale loops_per_jiffy in SMP systems# Russell King - ARM Linux
2014-05-09 18:00 ` Nicolas Pitre
2014-05-09 18:22 ` Russell King - ARM Linux
2014-05-09 21:05 ` Nicolas Pitre
2014-05-12 23:51 ` Doug Anderson
2014-05-13 21:50 ` Doug Anderson
2014-05-13 22:15 ` Stephen Warren
2014-05-13 23:15 ` Nicolas Pitre
2014-05-13 23:29 ` Nicolas Pitre
2014-05-13 23:36 ` Russell King - ARM Linux
2014-05-14 21:42 ` Doug Anderson
2014-05-15 6:12 ` Viresh Kumar
2014-05-09 9:25 ` [PATCH] ARM: Don't ever downscale loops_per_jiffy in SMP systems Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140508205556.GJ3693@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=davidriley@chromium.org \
--cc=dianders@chromium.org \
--cc=john.stultz@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=nicolas.pitre@linaro.org \
--cc=olof@lixom.net \
--cc=paul.gortmaker@windriver.com \
--cc=richard.zhao@linaro.org \
--cc=rjw@rjwysocki.net \
--cc=santosh.shilimkar@ti.com \
--cc=sboyd@codeaurora.org \
--cc=shawn.guo@linaro.org \
--cc=sonnyrao@chromium.org \
--cc=swarren@nvidia.com \
--cc=viresh.kumar@linaro.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome