From: Daeseok Youn <daeseok.youn@gmail.com>
To: m.chehab@samsung.com
Cc: sakari.ailus@iki.fi, linux-dev@sensoray.com,
hans.verkuil@cisco.com, linux-media@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH] [media] s2255drv: fix memory leak s2255_probe()
Date: Fri, 9 May 2014 07:57:18 +0900 [thread overview]
Message-ID: <20140508225718.GA24276@devel.8.8.4.4> (raw)
smatch says:
drivers/media/usb/s2255/s2255drv.c:2246 s2255_probe() warn:
possible memory leak of 'dev'
Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com>
---
V2: use the same pattern for error handling.
drivers/media/usb/s2255/s2255drv.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/media/usb/s2255/s2255drv.c b/drivers/media/usb/s2255/s2255drv.c
index 1d4ba2b..3193474 100644
--- a/drivers/media/usb/s2255/s2255drv.c
+++ b/drivers/media/usb/s2255/s2255drv.c
@@ -2243,7 +2243,7 @@ static int s2255_probe(struct usb_interface *interface,
dev->cmdbuf = kzalloc(S2255_CMDBUF_SIZE, GFP_KERNEL);
if (dev->cmdbuf == NULL) {
s2255_dev_err(&interface->dev, "out of memory\n");
- return -ENOMEM;
+ goto errorFWDATA1;
}
atomic_set(&dev->num_channels, 0);
--
1.7.1
next reply other threads:[~2014-05-08 22:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-08 22:57 Daeseok Youn [this message]
2014-05-09 7:32 ` Sakari Ailus
-- strict thread matches above, loose matches on Subject: below --
2014-04-15 4:49 Daeseok Youn
2014-04-15 9:33 ` Sakari Ailus
2014-04-15 10:54 ` DaeSeok Youn
2014-05-05 8:38 ` Sakari Ailus
2014-05-07 4:38 ` DaeSeok Youn
2014-05-08 11:21 ` Sakari Ailus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140508225718.GA24276@devel.8.8.4.4 \
--to=daeseok.youn@gmail.com \
--cc=hans.verkuil@cisco.com \
--cc=linux-dev@sensoray.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=m.chehab@samsung.com \
--cc=sakari.ailus@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®