From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757721AbaEJBTS (ORCPT ); Fri, 9 May 2014 21:19:18 -0400 Received: from mail-pd0-f181.google.com ([209.85.192.181]:50113 "EHLO mail-pd0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753378AbaEJBTR (ORCPT ); Fri, 9 May 2014 21:19:17 -0400 Date: Fri, 9 May 2014 18:19:13 -0700 From: Brian Norris To: Richard Weinberger , Artem Bityutskiy Cc: Mike Snitzer , linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH] UBI: fix rb_tree node comparison in add_map Message-ID: <20140510011913.GH28907@ld-irv-0074> References: <20140321195403.GA32529@redhat.com> <532CD1CB.4070707@nod.at> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <532CD1CB.4070707@nod.at> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Artem, On Sat, Mar 22, 2014 at 12:56:59AM +0100, Richard Weinberger wrote: > Am 21.03.2014 20:54, schrieb Mike Snitzer: > > The comparisons used in add_vol() shouldn't be identical. Pretty sure > > the following is correct but it is completely untested. > > > > Signed-off-by: Mike Snitzer > > --- > > drivers/mtd/ubi/fastmap.c | 4 ++-- > > 1 files changed, 2 insertions(+), 2 deletions(-) > > > > NOTE: I stumbled upon this code while implementing some rb_tree code > > (and looking for some existing rb_tree code as a reference). > > Thanks a lot for pointing this out! > > Acked-by: Richard Weinberger Bump? I'm passing through my queue, and I occasionally see some obvious, reviewed fixes like this one. Typically, you get around to them eventually, but you never know. Do you prefer the "bump"? Brian