From: Jean Delvare <jdelvare@suse.de>
To: Josef Gajdusek <atx@atx.name>
Cc: linux@roeck-us.net, lm-sensors@lm-sensors.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers/hwmon: bugfix and support for emc1412 in emc1403.c
Date: Sun, 11 May 2014 13:12:28 +0200 [thread overview]
Message-ID: <20140511131228.019bdba5@endymion.delvare> (raw)
In-Reply-To: <20140511103152.GA5631@dashie>
Hi Josef,
On Sun, 11 May 2014 12:31:52 +0200, Josef Gajdusek wrote:
> Adds support for emc1412 to emc1403.c + minor bugfix
>
> * Renamed generic thermal_* prefixed names to emc1403_*
Why? This adds a lot of noise to your patch and the benefit isn't
obvious. If you really want to do that, then it should be a separate
patch.
> * Fixed set_hyst being broken (i. e. writing 86000 set hysteresis to 84000)
Bug fixes should be sent as separate patches, so that they can be
ported back to stable, long-term and distribution kernels.
> * Added support for emc1412
>
> Signed-off-by: Josef Gajdusek <atx@atx.name>
> +MODULE_ALIAS("i2c:emc1403");
Why add an alias which is already present?
--
Jean Delvare
SUSE L3 Support
next prev parent reply other threads:[~2014-05-11 11:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-11 10:31 Josef Gajdusek
2014-05-11 11:12 ` Jean Delvare [this message]
2014-05-11 11:27 ` Re[2]: " atx
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140511131228.019bdba5@endymion.delvare \
--to=jdelvare@suse.de \
--cc=atx@atx.name \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=lm-sensors@lm-sensors.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®