From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755728AbaEKPB6 (ORCPT ); Sun, 11 May 2014 11:01:58 -0400 Received: from mho-02-ewr.mailhop.org ([204.13.248.72]:28238 "EHLO mho-02-ewr.mailhop.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751378AbaEKPB4 (ORCPT ); Sun, 11 May 2014 11:01:56 -0400 X-Mail-Handler: Dyn Standard SMTP by Dyn X-Originating-IP: 99.127.230.128 X-Report-Abuse-To: abuse@dyndns.com (see http://www.dyndns.com/services/sendlabs/outbound_abuse.html for abuse reporting information) X-MHO-User: U2FsdGVkX1+c/nPBB7oZdhMfuttsTuv+ Date: Sun, 11 May 2014 08:01:46 -0700 From: Tony Lindgren To: Aaro Koskinen Cc: Tomi Valkeinen , Peter Griffin , Arnd Bergmann , linux-kernel@vger.kernel.org, linaro-kernel@lists.linaro.org, Jean-Christophe Plagniol-Villard , linux-fbdev@vger.kernel.org, linux-omap@vger.kernel.org, Janusz Krzysztofik Subject: Re: [PATCH 13/13] video: omap: allow building on !MMU Message-ID: <20140511150146.GB28266@atomide.com> References: <1398342509-10243-1-git-send-email-peter.griffin@linaro.org> <1398342509-10243-14-git-send-email-peter.griffin@linaro.org> <5369F973.10803@ti.com> <20140508215338.GE2198@atomide.com> <20140508230415.GA6670@drone.musicnaut.iki.fi> <20140508231711.GF2198@atomide.com> <20140509212112.GB6670@drone.musicnaut.iki.fi> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20140509212112.GB6670@drone.musicnaut.iki.fi> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Aaro Koskinen [140509 14:26]: > Hi, > > On Thu, May 08, 2014 at 04:17:11PM -0700, Tony Lindgren wrote: > > > OMAP1 fb is working very well. As a matter of fact, it's much more usable > > > for me than fb on OMAP2/3 - apart from N900 (on which fb is working again > > > with 3.15) none of my 4 other OMAP2/3 boards have a working display/fb > > > in mainline yet. :-( > > > > I hear you.. What do you have in the .config for omap1? > > Would be nice to enable the framebuffer in omap1_defconfig? > > Looks like the needed stuff is enabled there. Unfortunately I cannot > test the full omap1_defconfig because of size limitations. OK maybe it's just a question of loading the backlight modules. > > > > > Tony, any idea of omap1's fb? Are you able to test this? > > > > > > > > I have three omap1 boards in my rack that I use for my boot > > > > testing. Tried to enable framebuffer but so far no luck on > > > > any of them. So I'm not much of a help here. Looks like the > > > > patch should work though.. > > > > > > > > Aaro & Janusz, care to take a look at the patch in this > > > > thread? > > > > > > I couldn't figure out how to enter this code path. Amstrad E3 & Nokia > > > 770 will take the alloc_fbmem() path & exit, and based on quick look > > > I could not see way to enter mmap_kern(). Is that dead code? > > > > Could be. It may be something left from when we had code to keep > > the bootloader logo displayed while booting kernel. > > The support for early fbmem alloc was removed in 2011 > (1e434f9318efc3dddc0c0b8d2071712668154c2b, OMAPFB: remove early mem > alloc from old omapfb), so I think we can safely delete this code. > I can prepare & test a patch for this. OK thanks that makes sense to me. Regards, Tony