From: Jean Delvare <jdelvare@suse.de>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Josef Gajdusek <atx@atx.name>,
lm-sensors@lm-sensors.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers/hwmon/emc1403.c: add support for emc1412
Date: Mon, 12 May 2014 08:10:51 +0200 [thread overview]
Message-ID: <20140512081051.29333503@endymion.delvare> (raw)
In-Reply-To: <536FFC55.2080009@roeck-us.net>
Hi Guenter, Josef,
On Sun, 11 May 2014 15:40:21 -0700, Guenter Roeck wrote:
> On 05/11/2014 06:00 AM, Josef Gajdusek wrote:
> > @@ -366,14 +433,19 @@ static int emc1403_probe(struct i2c_client *client,
> > }
> >
> > static const unsigned short emc1403_address_list[] = {
> > - 0x18, 0x29, 0x4c, 0x4d, I2C_CLIENT_END
> > + /* emc1403/emc1404/emc1423/emc1424 */
> > + 0x4c, 0x4d, 0x18, 0x29,
> > + /* emc1412 */
> > + 0x5c, 0x4c, 0x6c, 0x1c, 0x3c, I2C_CLIENT_END
>
> No duplication of addresses, and addresses are by convention in order.
> Jean, any addresses which should not be scanned ?
0x3c and 0x6c should indeed not be scanned, sensors-detect does not
scan them as they aren't typically used by hwmon devices. 0x5c is
questionable (currently scanned, but used only by a limited number of
chips, we may drop it at some point.) 0x1c and 0x4c are OK to scan.
--
Jean Delvare
SUSE L3 Support
next prev parent reply other threads:[~2014-05-12 6:10 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-11 13:00 Josef Gajdusek
2014-05-11 22:40 ` Guenter Roeck
2014-05-12 2:20 ` [lm-sensors] " Guenter Roeck
2014-05-12 6:10 ` Jean Delvare [this message]
2014-05-12 15:59 ` Guenter Roeck
2014-05-12 16:48 ` Jean Delvare
2014-05-12 18:09 ` Guenter Roeck
2014-05-11 22:47 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140512081051.29333503@endymion.delvare \
--to=jdelvare@suse.de \
--cc=atx@atx.name \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=lm-sensors@lm-sensors.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®