From: Steven Rostedt <rostedt@goodmis.org>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Dongsheng Yang <dongsheng081251@gmail.com>,
"yangds.fnst" <yangds.fnst@cn.fujitsu.com>,
linux-kernel@vger.kernel.org, mingo@redhat.com,
bsegall@google.com
Subject: Re: [PATCH] sched: Distinguish sched_wakeup event when wake up a task which did schedule out or not.
Date: Mon, 12 May 2014 10:09:08 -0400 [thread overview]
Message-ID: <20140512100908.07cc50bc@gandalf.local.home> (raw)
In-Reply-To: <20140512064730.GI30445@twins.programming.kicks-ass.net>
On Mon, 12 May 2014 08:47:30 +0200
Peter Zijlstra <peterz@infradead.org> wrote:
> But that has nothing what so fucking ever to do with 'success'. Reusing
> that trace argument for something entirely different is just retarded.
And having a "success" field that his hard coded to "true" is also
retarded. At least this change is fucking useful.
How about this. Add a new field called 'rq_added' or something. We can
ever shrink the size of the "success" field and hard code it to true in
the trace. That will never change. Then the caller of the tracepoint
will send in a "true" or "false" to "rq_added" and we can add that
tracepoint as well.
What I mean by shrink the size of the success field is that it is
currently 4 bytes in size. We can make it two (or one) and then add
another field for the 'rq_added' and have that be two bytes as well.
This shouldn't break any tools that use this.
Point being, this is useful information, why not pass it to userspace?
-- Steve
next prev parent reply other threads:[~2014-05-12 14:09 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-15 12:32 [PATCH 0/8] perf sched: Add trace event for sched wait Dongsheng Yang
2014-04-15 12:32 ` [PATCH 1/8] sched & trace: Add a trace event for wait Dongsheng Yang
2014-04-15 13:49 ` Peter Zijlstra
2014-04-16 14:23 ` Steven Rostedt
2014-04-15 12:32 ` [PATCH 2/8] sched/wait: Add trace point before add task into wait queue Dongsheng Yang
2014-04-15 12:32 ` [PATCH 3/8] sched/wait: Use __add_wait_queue{_tail}_exclusive() as possible Dongsheng Yang
2014-04-15 13:49 ` Peter Zijlstra
2014-04-16 9:51 ` Dongsheng Yang
2014-04-15 12:32 ` [PATCH 4/8] sched/core: Skip wakeup when task is already running Dongsheng Yang
2014-04-15 13:53 ` Peter Zijlstra
2014-04-16 10:22 ` Dongsheng Yang
2014-04-22 11:56 ` Dongsheng Yang
2014-04-22 13:23 ` Peter Zijlstra
2014-04-22 17:10 ` bsegall
2014-04-22 17:53 ` Steven Rostedt
2014-04-22 18:18 ` Peter Zijlstra
2014-05-05 6:32 ` Dongsheng Yang
2014-05-05 6:34 ` [PATCH] sched: Move the wakeup tracepoint from ttwu_do_wakeup() to ttwu_activate() Dongsheng Yang
2014-05-05 14:00 ` Steven Rostedt
2014-05-06 0:19 ` Dongsheng Yang
2014-05-06 0:26 ` Dongsheng Yang
2014-05-06 2:06 ` Steven Rostedt
2014-05-06 1:29 ` Dongsheng Yang
2014-05-06 1:52 ` [PATCH] sched: Distinguish sched_wakeup event when wake up a task which did schedule out or not Dongsheng Yang
2014-05-09 0:16 ` Dongsheng Yang
2014-05-09 1:27 ` Steven Rostedt
2014-05-10 15:29 ` Peter Zijlstra
[not found] ` <536F90BE.2080806@gmail.com>
2014-05-11 15:24 ` Fwd: " Dongsheng Yang
2014-05-11 16:35 ` Peter Zijlstra
2014-05-11 18:52 ` Steven Rostedt
2014-05-12 6:47 ` Peter Zijlstra
2014-05-12 8:58 ` Dongsheng Yang
2014-05-12 14:09 ` Steven Rostedt [this message]
2014-05-12 15:09 ` Peter Zijlstra
2014-05-12 15:17 ` Steven Rostedt
2014-05-12 15:28 ` Peter Zijlstra
2014-04-15 12:32 ` [PATCH 5/8] perf tools: record and process sched:sched_wait event Dongsheng Yang
2014-04-15 12:32 ` [PATCH 6/8] perf tools: add missing event for perf sched record Dongsheng Yang
2014-04-15 12:32 ` [PATCH 7/8] perf tools: Adapt the TASK_STATE_TO_CHAR_STR to new value in kernel space Dongsheng Yang
2014-04-15 12:32 ` [PATCH 8/8] perf tools: Clarify the output of perf sched map Dongsheng Yang
2014-04-15 13:54 ` [PATCH 0/8] perf sched: Add trace event for sched wait Peter Zijlstra
2014-04-16 10:28 ` Dongsheng Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140512100908.07cc50bc@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=bsegall@google.com \
--cc=dongsheng081251@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=yangds.fnst@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®