From: Andrew Morton <akpm@linux-foundation.org>
To: Fabian Frederick <fabf@skynet.be>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
David Howells <dhowells@redhat.com>
Subject: Re: [PATCH 1/2] FS/CACHEFILES: convert printk to pr_foo()
Date: Mon, 12 May 2014 13:43:25 -0700 [thread overview]
Message-ID: <20140512134325.e16b48e91cca8ca1e3f9f63b@linux-foundation.org> (raw)
In-Reply-To: <20140512200445.edee2954e66a1d2ec4cf31ca@skynet.be>
On Mon, 12 May 2014 20:04:45 +0200 Fabian Frederick <fabf@skynet.be> wrote:
>
> --- a/fs/cachefiles/bind.c
> +++ b/fs/cachefiles/bind.c
> @@ -228,9 +228,8 @@ static int cachefiles_daemon_add_cache(struct cachefiles_cache *cache)
> set_bit(CACHEFILES_READY, &cache->flags);
> dput(root);
>
> - printk(KERN_INFO "CacheFiles:"
> - " File cache on %s registered\n",
> - cache->cache.identifier);
> + pr_info("CacheFiles: File cache on %s registered\n",
> + cache->cache.identifier);
Why are we using "CacheFiles: " everywhere? Can't this be done via pr_fmt()?
prev parent reply other threads:[~2014-05-12 20:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-12 18:04 Fabian Frederick
2014-05-12 20:43 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140512134325.e16b48e91cca8ca1e3f9f63b@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=dhowells@redhat.com \
--cc=fabf@skynet.be \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®