From: Andrew Morton <akpm@linux-foundation.org>
To: Tejun Heo <tj@kernel.org>
Cc: George Spelvin <linux@horizon.com>,
linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org,
mingo@redhat.com, torvalds@linux-foundation.org
Subject: Re: [PATCH 1/2] Add lib/glob.c
Date: Mon, 12 May 2014 16:03:51 -0700 [thread overview]
Message-ID: <20140512160351.c0f7b25d7fa79e1cb19d6a79@linux-foundation.org> (raw)
In-Reply-To: <20140510122138.GA4721@mtj.dyndns.org>
On Sat, 10 May 2014 08:21:38 -0400 Tejun Heo <tj@kernel.org> wrote:
> > +int
> > +main(void)
> > +{
> > + size_t i;
> > +
> > + for (i = 0; i < sizeof(tests)/sizeof(*tests); i++)
> > + test(tests + i);
> > +
> > + return 0;
> > +}
> > +
> > +#endif /* UNITTEST */
>
> Again, I don't really think the userland testing code belongs here.
> If you wanna keep them, please make it in-kernel selftesting. We
> don't really wanna keep code which can't get built and tested in
> kernel tree proper.
If the tests don't measurably increase boot times we could run them
unconditionally at boot. Mark everything __init/__initdata and
the costs are very low. lib/plist.c does this.
next prev parent reply other threads:[~2014-05-12 23:03 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20140313121032.GA9981@htj.dyndns.org>
2014-05-10 3:13 ` George Spelvin
2014-05-10 3:14 ` [PATCH 2/2] libata: Use glob_match from lib/glob.c George Spelvin
2014-05-10 12:21 ` [PATCH 1/2] Add lib/glob.c Tejun Heo
2014-05-11 6:02 ` George Spelvin
2014-05-12 23:03 ` Andrew Morton [this message]
2014-05-10 12:23 ` Tejun Heo
2014-05-10 14:03 ` George Spelvin
2014-05-10 17:22 ` Randy Dunlap
2014-05-10 17:29 ` Randy Dunlap
2014-05-11 12:36 ` Tejun Heo
2014-06-07 2:44 ` [PATCH v2 1/3] " George Spelvin
2014-06-07 2:49 ` [PATCH v2 2/3] lib: glob.c: Add CONFIG_GLOB_SELFTEST George Spelvin
2014-06-11 23:04 ` Andrew Morton
2014-06-12 1:38 ` George Spelvin
2014-06-07 2:50 ` [PATCH v2 3/3] libata: Use glob_match from lib/glob.c George Spelvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140512160351.c0f7b25d7fa79e1cb19d6a79@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@horizon.com \
--cc=mingo@redhat.com \
--cc=tj@kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome