From: Richard Guy Briggs <rgb@redhat.com>
To: Eric Paris <eparis@redhat.com>
Cc: linux-audit@redhat.com, linux-kernel@vger.kernel.org,
containers@lists.linux-foundation.org, arozansk@redhat.com,
serge@hallyn.com, ebiederm@xmission.com, sgrubb@redhat.com
Subject: Re: [PATCH V2 2/6] audit: log namespace serial numbers
Date: Tue, 13 May 2014 10:28:22 -0400 [thread overview]
Message-ID: <20140513142822.GC27560@madcap2.tricolour.ca> (raw)
In-Reply-To: <1399737362.3558.22.camel@localhost>
On 14/05/10, Eric Paris wrote:
> On Fri, 2014-05-09 at 20:27 -0400, Richard Guy Briggs wrote:
>
> Not so relevant because you delete all of this code later... But
> still...
>
> > +#ifdef CONFIG_NAMESPACES
> > +void audit_log_namespace_info(struct audit_buffer *ab, struct task_struct *tsk)
> > +{
> > + struct nsproxy *nsproxy;
> > +
> > + rcu_read_lock();
>
> ok, so we are under rcu_read_lock() and cannot sleep
>
> > + nsproxy = task_nsproxy(tsk);
> > + if (nsproxy != NULL) {
> > + audit_log_format(ab, " mntns=%llx", nsproxy->mnt_ns->serial_num);
>
> But this could do an allocation, are we sure that everything used
> GFP_ATOMIC when creating the audit buffer? [hint: it doesn't]
Ugh, missed that. Even more reason to go with the ns_entries export.
- RGB
--
Richard Guy Briggs <rbriggs@redhat.com>
Senior Software Engineer, Kernel Security, AMER ENG Base Operating Systems, Red Hat
Remote, Ottawa, Canada
Voice: +1.647.777.2635, Internal: (81) 32635, Alt: +1.613.693.0684x3545
next prev parent reply other threads:[~2014-05-13 14:28 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-10 0:27 [PATCH V2 0/6] namespaces: log namespaces per task Richard Guy Briggs
2014-05-10 0:27 ` [PATCH V2 1/6] namespaces: assign each namespace instance a serial number Richard Guy Briggs
2014-05-10 15:01 ` Eric Paris
2014-05-13 14:39 ` Richard Guy Briggs
2014-05-13 15:13 ` Richard Guy Briggs
2014-05-13 15:30 ` Eric Paris
2014-05-13 18:44 ` Eric Paris
2014-05-10 0:27 ` [PATCH V2 2/6] audit: log namespace serial numbers Richard Guy Briggs
2014-05-10 15:07 ` Eric Paris
2014-05-13 14:19 ` Richard Guy Briggs
2014-05-10 15:56 ` Eric Paris
2014-05-13 14:28 ` Richard Guy Briggs [this message]
2014-05-10 0:27 ` [PATCH V2 3/6] namespaces: expose namespace instance serial number in proc_ns_operations Richard Guy Briggs
2014-05-10 0:27 ` [PATCH V2 4/6] namespaces: expose ns instance serial numbers in proc Richard Guy Briggs
2014-05-10 0:27 ` [PATCH V2 5/6] namespaces: expose ns_entries Richard Guy Briggs
2014-05-10 0:27 ` [PATCH V2 6/6] audit: convert namespace serial number logging to use proc ns_entries Richard Guy Briggs
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140513142822.GC27560@madcap2.tricolour.ca \
--to=rgb@redhat.com \
--cc=arozansk@redhat.com \
--cc=containers@lists.linux-foundation.org \
--cc=ebiederm@xmission.com \
--cc=eparis@redhat.com \
--cc=linux-audit@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=serge@hallyn.com \
--cc=sgrubb@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®