From: Dave Young <dyoung@redhat.com>
To: keescook@chromium.org, hpa@zytor.com, linux-kernel@vger.kernel.org
Subject: [PATCH] x86: kaslr to avoid setup_data regions
Date: Wed, 14 May 2014 15:49:40 +0800 [thread overview]
Message-ID: <20140514074940.GA18774@dhcp-16-198.nay.redhat.com> (raw)
X86 will pass setup_data region while necessary, these regions could be
overwitten by kernel due to kaslr.
Thus iterate and add setup regions to mem_avoid[] in this patch.
Set max mem avoid entries 32, hopefully it will be enough.
Signed-off-by: Dave Young <dyoung@redhat.com>
---
arch/x86/boot/compressed/aslr.c | 28 +++++++++++++++++++++++++++-
1 file changed, 27 insertions(+), 1 deletion(-)
Index: linux-2.6/arch/x86/boot/compressed/aslr.c
===================================================================
--- linux-2.6.orig/arch/x86/boot/compressed/aslr.c
+++ linux-2.6/arch/x86/boot/compressed/aslr.c
@@ -110,8 +110,9 @@ struct mem_vector {
unsigned long size;
};
-#define MEM_AVOID_MAX 5
+#define MEM_AVOID_MAX 32
static struct mem_vector mem_avoid[MEM_AVOID_MAX];
+static int mem_avoid_nr;
static bool mem_contains(struct mem_vector *region, struct mem_vector *item)
{
@@ -135,6 +136,28 @@ static bool mem_overlaps(struct mem_vect
return true;
}
+static void mem_avoid_setup_data(void)
+{
+ struct setup_data *data;
+ u64 pa_data;
+
+ if (mem_avoid_nr >= MEM_AVOID_MAX) {
+ debug_putstr("KASLR: too many setup_data ranges.\n");
+ return;
+ }
+
+ pa_data = real_mode->hdr.setup_data;
+ while (pa_data) {
+ data = (struct setup_data *)pa_data;
+ if (pa_data < CONFIG_RANDOMIZE_BASE_MAX_OFFSET) {
+ mem_avoid[mem_avoid_nr].start = pa_data;
+ mem_avoid[mem_avoid_nr].size = sizeof(*data) + data->len;
+ mem_avoid_nr++;
+ }
+ pa_data = data->next;
+ }
+}
+
static void mem_avoid_init(unsigned long input, unsigned long input_size,
unsigned long output, unsigned long output_size)
{
@@ -177,6 +200,9 @@ static void mem_avoid_init(unsigned long
/* Avoid stack memory. */
mem_avoid[4].start = (unsigned long)free_mem_end_ptr;
mem_avoid[4].size = BOOT_STACK_SIZE;
+ mem_avoid_nr = 5;
+
+ mem_avoid_setup_data();
}
/* Does this memory vector overlap a known avoided area? */
next reply other threads:[~2014-05-14 7:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-14 7:49 Dave Young [this message]
2014-05-14 8:09 ` Dave Young
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140514074940.GA18774@dhcp-16-198.nay.redhat.com \
--to=dyoung@redhat.com \
--cc=hpa@zytor.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®