From: Jan Kara <jack@suse.cz>
To: Mateusz Guzik <mguzik@redhat.com>
Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
Josef Bacik <jbacik@fb.com>, Jan Kara <jack@suse.cz>,
Al Viro <viro@ZenIV.linux.org.uk>,
Eric Sandeen <esandeen@redhat.com>, Joe Perches <joe@perches.com>
Subject: Re: [PATCH V2 2/2] fs: print a message when freezing/unfreezing filesystems
Date: Wed, 14 May 2014 13:14:49 +0200 [thread overview]
Message-ID: <20140514111449.GB5824@quack.suse.cz> (raw)
In-Reply-To: <1400018683-5565-2-git-send-email-mguzik@redhat.com>
On Wed 14-05-14 00:04:43, Mateusz Guzik wrote:
> This helps hang troubleshooting efforts when only dmesg is available.
>
> While here remove code duplication with MS_RDONLY case and fix a
> whitespace nit.
I'm somewhat undecided here I have to say. On one hand I don't like
printing to kernel log when everything is fine and kernel is operating
normally. On the other hand I've seen quite a few cases where people have
shot themselves in the foot with filesystem freezing so having some trace
of this in the log doesn't seem like a completely bad thing either. What do
other people think?
Honza
> Signed-off-by: Mateusz Guzik <mguzik@redhat.com>
> Cc: linux-fsdevel@vger.kernel.org
> Cc: Josef Bacik <jbacik@fb.com>
> Cc: Jan Kara <jack@suse.cz>
> Cc: Al Viro <viro@ZenIV.linux.org.uk>
> Cc: Eric Sandeen <esandeen@redhat.com>
> Cc: Joe Perches <joe@perches.com>
> ---
> since v1:
> fix copy-pasto which found its way into the patch
> restore curly brackets in MS_RDONLY case
> fs/super.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/fs/super.c b/fs/super.c
> index 017e10a..4dd7356 100644
> --- a/fs/super.c
> +++ b/fs/super.c
> @@ -1291,9 +1291,7 @@ int freeze_super(struct super_block *sb)
>
> if (sb->s_flags & MS_RDONLY) {
> /* Nothing to do really... */
> - sb->s_writers.frozen = SB_FREEZE_COMPLETE;
> - up_write(&sb->s_umount);
> - return 0;
> + goto out;
> }
>
> /* From now on, no new normal writers can start */
> @@ -1335,8 +1333,10 @@ int freeze_super(struct super_block *sb)
> * This is just for debugging purposes so that fs can warn if it
> * sees write activity when frozen is set to SB_FREEZE_COMPLETE.
> */
> +out:
> sb->s_writers.frozen = SB_FREEZE_COMPLETE;
> up_write(&sb->s_umount);
> + pr_info("VFS:Filesystem %s frozen\n", sb->s_id);
> return 0;
> }
> EXPORT_SYMBOL(freeze_super);
> @@ -1374,7 +1374,7 @@ out:
> smp_wmb();
> wake_up(&sb->s_writers.wait_unfrozen);
> deactivate_locked_super(sb);
> -
> + pr_info("VFS:Filesystem %s thawed\n", sb->s_id);
> return 0;
> }
> EXPORT_SYMBOL(thaw_super);
> --
> 1.8.3.1
>
--
Jan Kara <jack@suse.cz>
SUSE Labs, CR
next prev parent reply other threads:[~2014-05-14 11:14 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-13 22:04 [PATCH V2 1/2] fs: include device name in error messages about freezing Mateusz Guzik
2014-05-13 22:04 ` [PATCH V2 2/2] fs: print a message when freezing/unfreezing filesystems Mateusz Guzik
2014-05-14 11:14 ` Jan Kara [this message]
2014-05-14 11:26 ` Mateusz Guzik
2014-05-14 11:39 ` Jan Kara
2014-05-14 22:00 ` Dave Chinner
2014-05-14 22:37 ` Dave Chinner
2014-05-14 22:40 ` Eric Sandeen
2014-05-15 10:40 ` Lukáš Czerner
2014-05-15 10:47 ` Mateusz Guzik
2014-05-15 22:21 ` Dave Chinner
2014-05-15 22:34 ` Mateusz Guzik
2014-05-15 22:51 ` Dave Chinner
2014-05-15 23:19 ` Mateusz Guzik
2014-05-16 0:11 ` Dave Chinner
2014-05-16 0:39 ` Mateusz Guzik
2014-05-19 9:43 ` Jan Kara
2014-05-19 23:37 ` Dave Chinner
2014-05-15 10:13 ` Jan Kara
2014-05-15 22:16 ` Dave Chinner
2014-05-14 11:58 ` Lukáš Czerner
2014-05-14 11:10 ` [PATCH V2 1/2] fs: include device name in error messages about freezing Jan Kara
2014-05-14 22:07 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140514111449.GB5824@quack.suse.cz \
--to=jack@suse.cz \
--cc=esandeen@redhat.com \
--cc=jbacik@fb.com \
--cc=joe@perches.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mguzik@redhat.com \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®