mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Grant Likely <grant.likely@secretlab.ca>
To: Michael Stickel <ms@mycable.de>
Cc: Pantelis Antoniou <pantelis.antoniou@konsulko.com>,
	Rob Herring <robherring2@gmail.com>,
	Stephen Warren <swarren@wwwdotorg.org>,
	Matt Porter <matt.porter@linaro.org>,
	Koen Kooi <koen@dominion.thruhere.net>,
	Alison Chaiken <Alison_Chaiken@mentor.com>,
	Dinh Nguyen <dinh.linux@gmail.com>, Jan Lubbe <jluebbe@lasnet.de>,
	Alexander Sverdlin <alexander.sverdlin@nsn.com>,
	Guenter Roeck <linux@roeck-us.net>,
	Dirk Behme <dirk.behme@gmail.com>,
	Alan Tull <delicious.quinoa@gmail.com>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Michael Bohan <mbohan@codeaurora.org>,
	Ionut Nicu <ioan.nicu.ext@nsn.com>,
	Michal Simek <monstr@monstr.eu>,
	Matt Ranostay <mranostay@gmail.com>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	Pete Popov <pete.popov@konsulko.com>,
	Dan Malek <dan.malek@konsulko.com>,
	Georgi Vlaev <georgi.vlaev@konsulko.com>,
	Pantelis Antoniou <panto@antoniou-consulting.com>
Subject: Re: [PATCH v4 2/8] OF: Introduce DT overlay support.
Date: Wed, 14 May 2014 16:49:07 +0100	[thread overview]
Message-ID: <20140514154907.BC65DC40BD2@trevor.secretlab.ca> (raw)
In-Reply-To: <53735D88.5090108@mycable.de>

On Wed, 14 May 2014 14:11:52 +0200, Michael Stickel <ms@mycable.de> wrote:
> Hi Grant,
> 
> Am 14.05.2014 12:08, schrieb Grant Likely:
> > More generally I am concerned about whether or not overlays
> > will introduce corner cases that can never be handled correctly,
> > particularly in how multiple overlays will get handled. I want to see
> > very clear rules on what happens when multiple overlays are applied, and
> > then removed again. Is it possible to remove overlays out of order? If
> > so, what are the conditions that would not be allowed?
> 
> Yes, it is possible that an overlay depends on another.
> 
> The problem is not, that an overlay is removed other overlays depend on,
> but that nodes of an overlay may depend on the to-be-removed overlay and
> the resulting devicetree can become inconsistent.

So what should the rule be then? It sounds to me that it should be a
hard and fast rule for overlays to always be removed in-order. If two
overlays are applied, and the first one needs to be removed again, then
that forces a removal of the second. The code needs to enforce it too.

The question can be revisited if someone can find a way to validate
overlays do not conflict.

g.


  reply	other threads:[~2014-05-14 15:49 UTC|newest]

Thread overview: 50+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-04 12:43 [PATCH v4 0/8] Introducing (yet again) Device Tree Overlays Pantelis Antoniou
2014-04-04 12:43 ` [PATCH v4 1/8] OF: Introduce Device Tree resolve support Pantelis Antoniou
2014-04-04 12:43 ` [PATCH v4 2/8] OF: Introduce DT overlay support Pantelis Antoniou
2014-05-14 10:08   ` Grant Likely
2014-05-14 12:11     ` Michael Stickel
2014-05-14 15:49       ` Grant Likely [this message]
2014-05-14 16:13         ` Guenter Roeck
2014-05-15  7:14       ` Pantelis Antoniou
2014-05-14 13:03     ` Geert Uytterhoeven
2014-05-14 13:18       ` Guenter Roeck
2014-05-15  7:15         ` Pantelis Antoniou
2014-05-14 15:34       ` Grant Likely
2014-05-15  7:12     ` Pantelis Antoniou
2014-05-15  7:20       ` Geert Uytterhoeven
2014-05-16 10:58         ` Grant Likely
2014-05-16 11:52           ` Geert Uytterhoeven
2014-05-20  5:50             ` Grant Likely
2014-05-20  7:38               ` Geert Uytterhoeven
2014-05-26 10:48                 ` Grant Likely
2014-05-26 10:57                   ` Geert Uytterhoeven
2014-05-26 11:08                     ` Pantelis Antoniou
2014-05-26 11:23                     ` Grant Likely
2014-05-26 11:55                       ` Pantelis Antoniou
2014-05-26 15:09                         ` Sebastian Reichel
2014-05-26 15:14                           ` Guenter Roeck
2014-05-26 23:00                             ` Sebastian Reichel
2014-05-26 15:14                           ` Pantelis Antoniou
2014-05-26 21:33                         ` Grant Likely
2014-05-26 21:44                           ` Geert Uytterhoeven
2014-05-26 23:47                             ` Guenter Roeck
2014-05-27 12:11                             ` Grant Likely
2014-05-26 22:36                           ` Sebastian Reichel
2014-05-26 23:42                             ` Guenter Roeck
2014-05-27  0:32                               ` Sebastian Reichel
2014-05-27  0:54                                 ` Guenter Roeck
2014-05-27 12:12                               ` Grant Likely
2014-05-27 12:24                                 ` Pantelis Antoniou
2014-05-27 15:21                                   ` Guenter Roeck
2014-05-27 15:38                                     ` Pantelis Antoniou
2014-05-27 17:52                                     ` Geert Uytterhoeven
2014-05-27 18:22                                       ` Guenter Roeck
2014-05-27 20:11                                   ` Grant Likely
2014-05-20 12:27               ` Pantelis Antoniou
2014-05-15 14:18       ` Grant Likely
2014-04-04 12:43 ` [PATCH v4 3/8] OF: DT-Overlay configfs interface Pantelis Antoniou
2014-04-04 12:43 ` [PATCH v4 4/8] OF: platform: Add overlay bus handler Pantelis Antoniou
2014-04-04 12:43 ` [PATCH v4 5/8] of: i2c: Export single device registration method Pantelis Antoniou
2014-04-04 12:43 ` [PATCH v4 6/8] OF: i2c: Add overlay bus handler Pantelis Antoniou
2014-04-04 12:44 ` [PATCH v4 7/8] OF: spi: " Pantelis Antoniou
2014-04-04 12:44 ` [PATCH v4 8/8] OF: selftest: Add overlay self-test support Pantelis Antoniou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140514154907.BC65DC40BD2@trevor.secretlab.ca \
    --to=grant.likely@secretlab.ca \
    --cc=Alison_Chaiken@mentor.com \
    --cc=alexander.sverdlin@nsn.com \
    --cc=dan.malek@konsulko.com \
    --cc=delicious.quinoa@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dinh.linux@gmail.com \
    --cc=dirk.behme@gmail.com \
    --cc=georgi.vlaev@konsulko.com \
    --cc=ioan.nicu.ext@nsn.com \
    --cc=jluebbe@lasnet.de \
    --cc=koen@dominion.thruhere.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=matt.porter@linaro.org \
    --cc=mbohan@codeaurora.org \
    --cc=monstr@monstr.eu \
    --cc=mranostay@gmail.com \
    --cc=ms@mycable.de \
    --cc=pantelis.antoniou@konsulko.com \
    --cc=panto@antoniou-consulting.com \
    --cc=pete.popov@konsulko.com \
    --cc=robherring2@gmail.com \
    --cc=s.hauer@pengutronix.de \
    --cc=swarren@wwwdotorg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®