From: Tejun Heo <tj@kernel.org>
To: lizefan@huawei.com
Cc: cgroups@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCHSET cgroup/for-3.16] cgroup: use css->refcnt for cgroup reference counting
Date: Wed, 14 May 2014 13:04:04 -0400 [thread overview]
Message-ID: <20140514170404.GC15690@htj.dyndns.org> (raw)
In-Reply-To: <1399670015-23463-1-git-send-email-tj@kernel.org>
On Fri, May 09, 2014 at 05:13:26PM -0400, Tejun Heo wrote:
> Hello,
>
> Currently, cgroup and css (cgroup_subsys_state) are separately
> reference counted. cgroup->refcnt is an atomic_t and css->refcnt is a
> percpu_ref. css is becoming the primary structural block and used
> widely in various operaitons. cgroup already has a css embedded in it
> (cgroup->dummy_css) to use as its proxy in such operations; however,
> there still are quite a few differences between cgroup and css
> handling limitng how cgroup->dummy_css can be used.
>
> This patchset makes cgroup use the embedded css's refcnt for reference
> counting. This closes one of the gaps between an cgroup embedded css,
> which is renamed to cgroup->self early in the patchset, and a normal
> css and will allow more unified handling of cgroups and csses. In
> addition, this makes cgroup refcnting use percpu_ref too, which is a
> lot more scalable than an atomic_t.
>
> Ultimately, it'd make things far simpler to assign a proper
> cgroup_subsys to the cgroup embedded csses and handle them the same as
> other csses; however, we can't yet do it thanks to multiple
> hierarchies as we end up with multiple csses of the same subsystem for
> the same task, but in the very long term, if multiple hierarchies can
> be removed, that's where it's headed.
>
> This patchset contains the following nine patches.
>
> 0001-cgroup-use-restart_syscall-for-mount-retries.patch
> 0002-cgroup-rename-cgroup-dummy_css-to-self-and-move-it-t.patch
> 0003-cgroup-separate-out-cgroup_has_live_children-from-cg.patch
> 0004-cgroup-move-check_for_release-parent-call-to-the-end.patch
> 0005-cgroup-move-cgroup-sibling-unlinking-to-cgroup_put.patch
> 0006-cgroup-remove-cgroup_destory_css_killed.patch
> 0007-cgroup-bounce-css-release-through-css-destroy_work.patch
> 0008-cgroup-enable-refcnting-for-root-csses.patch
> 0009-cgroup-use-cgroup-self.refcnt-for-cgroup-refcnting.patch
Applied to cgroup/for-3.16.
Thanks.
--
tejun
prev parent reply other threads:[~2014-05-14 17:04 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-09 21:13 Tejun Heo
2014-05-09 21:13 ` [PATCH 1/9] cgroup: use restart_syscall() for mount retries Tejun Heo
2014-05-14 2:53 ` Li Zefan
2014-05-14 13:12 ` [PATCH v2 " Tejun Heo
2014-05-09 21:13 ` [PATCH 2/9] cgroup: rename cgroup->dummy_css to ->self and move it to the top Tejun Heo
2014-05-09 21:13 ` [PATCH 3/9] cgroup: separate out cgroup_has_live_children() from cgroup_destroy_locked() Tejun Heo
2014-05-09 21:13 ` [PATCH 4/9] cgroup: move check_for_release(parent) call to the end of cgroup_destroy_locked() Tejun Heo
2014-05-09 21:13 ` [PATCH 5/9] cgroup: move cgroup->sibling unlinking to cgroup_put() Tejun Heo
2014-05-09 21:13 ` [PATCH 6/9] cgroup: remove cgroup_destory_css_killed() Tejun Heo
2014-05-09 21:13 ` [PATCH 7/9] cgroup: bounce css release through css->destroy_work Tejun Heo
2014-05-09 21:13 ` [PATCH 8/9] cgroup: enable refcnting for root csses Tejun Heo
2014-05-09 21:13 ` [PATCH 9/9] cgroup: use cgroup->self.refcnt for cgroup refcnting Tejun Heo
2014-05-15 19:07 ` Stephen Warren
2014-05-15 21:56 ` Stephen Warren
2014-05-16 14:37 ` Tejun Heo
2014-05-16 15:43 ` [PATCH cgroup/for-3.16] cgroup: introduce CSS_NO_REF and skip refcnting on normal root csses Tejun Heo
2014-05-16 16:59 ` Stephen Warren
2014-05-16 17:09 ` [PATCH v2 " Tejun Heo
2014-05-16 17:19 ` Stephen Warren
2014-05-16 17:23 ` Tejun Heo
2014-05-13 16:59 ` [PATCHSET cgroup/for-3.16] cgroup: use css->refcnt for cgroup reference counting Tejun Heo
2014-05-14 3:15 ` Li Zefan
2014-05-14 17:04 ` Tejun Heo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140514170404.GC15690@htj.dyndns.org \
--to=tj@kernel.org \
--cc=cgroups@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome