From: Andi Kleen <andi@firstfloor.org>
To: Stephane Eranian <eranian@google.com>
Cc: Don Zickus <dzickus@redhat.com>, Andi Kleen <andi@firstfloor.org>,
LKML <linux-kernel@vger.kernel.org>,
Ingo Molnar <mingo@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Arnaldo Carvalho de Melo <acme@ghostprotocols.net>,
Jiri Olsa <jolsa@redhat.com>, Joe Mario <jmario@redhat.com>
Subject: Re: Haswell mem-store question
Date: Thu, 15 May 2014 04:34:55 +0200 [thread overview]
Message-ID: <20140515023455.GB1873@two.firstfloor.org> (raw)
In-Reply-To: <CABPqkBQay_-KHkyFjMP5eq+8RYz1Uy7ske61qbpX5hPvvthw2g@mail.gmail.com>
> I think it should do:
>
> if (status & 1)
> dse.mem_lvl = PERF_MEM_LVL_L1|PERF_MEM_LVL_HIT;
> else
> dse.mem_lvl = PERF_MEM_LVL_L1|PERF_MEM_LVL_MISS;
>
> Otherwise you have L1 as the level with no hit/miss info.
Agreed.
BTW the line before is also not always corect, and any event not
explicitely store can only fill in NA
-Andi
prev parent reply other threads:[~2014-05-15 2:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-14 20:50 Don Zickus
2014-05-14 22:07 ` Stephane Eranian
2014-05-15 2:34 ` Andi Kleen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140515023455.GB1873@two.firstfloor.org \
--to=andi@firstfloor.org \
--cc=acme@ghostprotocols.net \
--cc=dzickus@redhat.com \
--cc=eranian@google.com \
--cc=jmario@redhat.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®