From: Daniel Vetter <daniel@ffwll.ch>
To: Ross Zwisler <ross.zwisler@linux.intel.com>
Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
Ingo Molnar <mingo@kernel.org>,
H Peter Anvin <h.peter.anvin@intel.com>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH] drm: Missed clflushopt in drm_clflush_virt_range
Date: Thu, 15 May 2014 14:38:47 +0200 [thread overview]
Message-ID: <20140515123846.GQ8790@phenom.ffwll.local> (raw)
In-Reply-To: <1400082072-22482-1-git-send-email-ross.zwisler@linux.intel.com>
On Wed, May 14, 2014 at 09:41:12AM -0600, Ross Zwisler wrote:
> With this commit:
>
> 2a0788dc9bc4 x86: Use clflushopt in drm_clflush_virt_range
>
> If clflushopt is available on the system, we use it instead of clflush
> in drm_clflush_virt_range. There were two calls to clflush in this
> function, but only one was changed to clflushopt. This patch changes
> the other clflush call to clflushopt.
>
> Signed-off-by: Ross Zwisler <ross.zwisler@linux.intel.com>
> Reported-by: Matthew Wilcox <matthew.r.wilcox@intel.com>
>
> Cc: David Airlie <airlied@linux.ie>
> Cc: dri-devel@lists.freedesktop.org
> Cc: H Peter Anvin <h.peter.anvin@intel.com>
> Cc: Ingo Molnar <mingo@kernel.org>
> Cc: Thomas Gleixner <tglx@linutronix.de>
Picked to my topic/core-stuff drm branch so it doesn't get lost.
-Daniel
>
> ---
> drivers/gpu/drm/drm_cache.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/drm_cache.c b/drivers/gpu/drm/drm_cache.c
> index 534cb89..041b73b 100644
> --- a/drivers/gpu/drm/drm_cache.c
> +++ b/drivers/gpu/drm/drm_cache.c
> @@ -138,7 +138,7 @@ drm_clflush_virt_range(char *addr, unsigned long length)
> char *end = addr + length;
> mb();
> for (; addr < end; addr += boot_cpu_data.x86_clflush_size)
> - clflush(addr);
> + clflushopt(addr);
> clflushopt(end - 1);
> mb();
> return;
> --
> 1.9.0
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
next prev parent reply other threads:[~2014-05-15 12:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-14 15:41 Ross Zwisler
2014-05-15 12:38 ` Daniel Vetter [this message]
2014-05-15 14:37 ` H. Peter Anvin
2014-05-15 20:40 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140515123846.GQ8790@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=h.peter.anvin@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=ross.zwisler@linux.intel.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®