From: Andrew Morton <akpm@linux-foundation.org>
To: riel@redhat.com
Cc: linux-kernel@vger.kernel.org, paulmck@linux.vnet.ibm.com,
rdunlap@infradead.org, richard@nod.at, umgwanakikbuti@gmail.com
Subject: Re: [PATCH 2/2] sysrq,rcu: suppress RCU stall warnings while sysrq runs
Date: Thu, 15 May 2014 16:24:12 -0700 [thread overview]
Message-ID: <20140515162412.51355f308c34768ad08c0e2f@linux-foundation.org> (raw)
In-Reply-To: <1398794796-17464-3-git-send-email-riel@redhat.com>
On Tue, 29 Apr 2014 14:06:36 -0400 riel@redhat.com wrote:
> From: Rik van Riel <riel@redhat.com>
>
> Some sysrq handlers can run for a long time, because they dump a lot
> of data onto a serial console. Having RCU stall warnings pop up in
> the middle of them only makes the problem worse.
>
> This patch temporarily disables RCU stall warnings while a sysrq
> request is handled.
>
> ...
>
> drivers/tty/sysrq.c | 3 +++
> include/linux/rcupdate.h | 12 ++++++++++++
> kernel/rcu/update.c | 12 ++++++++++++
OK, what's going on here. Someone (of, I suspect, a Paulish nature)
has plucked out the rcu parts of this patch, put them in linux-next and
omitted the drivers/tty part. Very tricky!
I have done the opposite and have staged two patches against linux-next:
http://ozlabs.org/~akpm/mmots/broken-out/sysrq-rcu-ify-__handle_sysrq.patch
http://ozlabs.org/~akpm/mmots/broken-out/sysrqrcu-suppress-rcu-stall-warnings-while-sysrq-runs.patch
Please check, review, comment, etc.
next prev parent reply other threads:[~2014-05-15 23:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-29 18:06 [PATCH 0/2] fixed sysrq & rcu patches riel
2014-04-29 18:06 ` [PATCH 1/2] sysrq: rcu-ify __handle_sysrq riel
2014-04-29 18:06 ` [PATCH 2/2] sysrq,rcu: suppress RCU stall warnings while sysrq runs riel
2014-05-15 23:24 ` Andrew Morton [this message]
2014-05-15 23:48 ` Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140515162412.51355f308c34768ad08c0e2f@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paulmck@linux.vnet.ibm.com \
--cc=rdunlap@infradead.org \
--cc=richard@nod.at \
--cc=riel@redhat.com \
--cc=umgwanakikbuti@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®