mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: "Clément Calmels" <clement.calmels@free.fr>
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: sep: fix coding style issue
Date: Thu, 15 May 2014 15:05:29 -0700	[thread overview]
Message-ID: <20140515220529.GA8459@kroah.com> (raw)
In-Reply-To: <1399398881-2611-1-git-send-email-clement.calmels@free.fr>

On Tue, May 06, 2014 at 07:54:41PM +0200, Clément Calmels wrote:
> This is a patch to fix coding style issue found by
> scripts/checkpatch.pl utility.
> 
> Signed-off-by: Clément Calmels <clement.calmels@free.fr>
> ---
>  drivers/staging/sep/sep_dev.h | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/staging/sep/sep_dev.h b/drivers/staging/sep/sep_dev.h
> index 5f6a07f..5faeefa1 100644
> --- a/drivers/staging/sep/sep_dev.h
> +++ b/drivers/staging/sep/sep_dev.h
> @@ -139,12 +139,14 @@ struct sep_queue_info {
>  static inline void sep_write_reg(struct sep_device *dev, int reg, u32 value)
>  {
>  	void __iomem *addr = dev->reg_addr + reg;
> +
>  	writel(value, addr);
>  }
>  
>  static inline u32 sep_read_reg(struct sep_device *dev, int reg)
>  {
>  	void __iomem *addr = dev->reg_addr + reg;
> +
>  	return readl(addr);
>  }
>  
> @@ -152,6 +154,7 @@ static inline u32 sep_read_reg(struct sep_device *dev, int reg)
>  static inline void sep_wait_sram_write(struct sep_device *dev)
>  {
>  	u32 reg_val;
> +
>  	do {
>  		reg_val = sep_read_reg(dev, HW_SRAM_DATA_READY_REG_ADDR);
>  	} while (!(reg_val & 1));

Someone else already sent in this same patch, sorry.

greg k-h

      reply	other threads:[~2014-05-15 22:02 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-06 17:54 Clément Calmels
2014-05-15 22:05 ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140515220529.GA8459@kroah.com \
    --to=greg@kroah.com \
    --cc=clement.calmels@free.fr \
    --cc=devel@driverdev.osuosl.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome