mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: Omar Ramirez Luna <omar.ramirez@copitl.com>,
	Masood Mehmood <ody.guru@gmail.com>,
	Dan Carpenter <dan.carpenter@oracle.com>,
	devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Fix for possible null pointer dereference in node.c
Date: Thu, 15 May 2014 15:08:08 -0700	[thread overview]
Message-ID: <20140515220808.GA13306@kroah.com> (raw)
In-Reply-To: <1400190833-27882-1-git-send-email-rickard_strandqvist@spectrumdigital.se>

On Thu, May 15, 2014 at 11:53:53PM +0200, Rickard Strandqvist wrote:
> There is otherwise a risk of a possible null pointer dereference.
> 
> Was largely found by using a static code analysis program called cppcheck.
> 
> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
> ---
>  drivers/staging/tidspbridge/rmgr/node.c |    4 ++--
>  1 fil ändrad, 2 tillägg(+), 2 borttagningar(-)

Please work a bit on your Subject lines to make it easier to figure out
where the patches belong.

For this one, it should be:
	Subject: staging: tidspridge: fix for possible null pointer dereference in node.c
or:
	Subject: staging: tidspridge: node.c: fix for possible null pointer dereference

That way people can figure out _what_ node.c file you are referring to
and to see if they care about it or not :)

thanks,

greg k-h

  reply	other threads:[~2014-05-15 22:04 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-15 21:53 Rickard Strandqvist
2014-05-15 22:08 ` Greg Kroah-Hartman [this message]
2014-05-15 22:14   ` Rickard Strandqvist
2014-05-15 22:43 ` Dan Carpenter
2014-05-17 13:21   ` Rickard Strandqvist
2014-05-17 18:56     ` Dan Carpenter
2014-05-18 15:49       ` Rickard Strandqvist
2014-05-18 16:22         ` Dan Carpenter
2014-05-18 17:14           ` Rickard Strandqvist

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140515220808.GA13306@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=dan.carpenter@oracle.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ody.guru@gmail.com \
    --cc=omar.ramirez@copitl.com \
    --cc=rickard_strandqvist@spectrumdigital.se \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome