From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932162AbaEPJcD (ORCPT ); Fri, 16 May 2014 05:32:03 -0400 Received: from mail-pa0-f41.google.com ([209.85.220.41]:40799 "EHLO mail-pa0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751475AbaEPJcA (ORCPT ); Fri, 16 May 2014 05:32:00 -0400 Date: Fri, 16 May 2014 18:31:23 +0900 From: Daeseok Youn To: plagnioj@jcrosoft.com Cc: tomi.valkeinen@ti.com, jg1.han@samsung.com, laurent.pinchart@ideasonboard.com, robdclark@gmail.com, daniel.vetter@ffwll.ch, Julia.Lawall@lip6.fr, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH V2] video : remove redundant error check Message-ID: <20140516093123.GA17245@devel.8.8.4.4> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.20 (2009-12-10) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org It doesn't need to check "err" for printing info. And also use pr_info instead of printk. Signed-off-by: Daeseok Youn --- V2: removes unneeded lines for sending a patch drivers/video/fbdev/i810/i810_main.c | 7 +++---- 1 files changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/video/fbdev/i810/i810_main.c b/drivers/video/fbdev/i810/i810_main.c index bb674e4..15cb397 100644 --- a/drivers/video/fbdev/i810/i810_main.c +++ b/drivers/video/fbdev/i810/i810_main.c @@ -1910,13 +1910,12 @@ static void i810fb_find_init_mode(struct fb_info *info) for (i = 0; i < par->ddc_num + 1; i++) { err = i810_probe_i2c_connector(info, &par->edid, i); - if (!err) + if (!err) { + pr_info("i810fb_init_pci: DDC probe successful\n"); break; + } } - if (!err) - printk("i810fb_init_pci: DDC probe successful\n"); - fb_edid_to_monspecs(par->edid, specs); if (specs->modedb == NULL) -- 1.7.1