From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754805AbaESNpO (ORCPT ); Mon, 19 May 2014 09:45:14 -0400 Received: from tex.lwn.net ([70.33.254.29]:55522 "EHLO vena.lwn.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751331AbaESNpL (ORCPT ); Mon, 19 May 2014 09:45:11 -0400 Date: Mon, 19 May 2014 07:45:10 -0600 From: Jake Edge To: Anton Saraev Cc: gregkh@linuxfoundation.org, jason@lakedaemon.net, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 06/06] staging: crypto: skein: rename files Message-ID: <20140519074510.74e622fd@chukar.edge2.net> In-Reply-To: References: <2eac124c6a3815c72e91679c8cde729af712bb74.1399675445.git.antonysaraev@gmail.com> X-Mailer: Claws Mail 3.9.3 (GTK+ 2.24.22; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 19 May 2014 12:09:59 +0400 Anton Saraev wrote: > --- a/drivers/staging/skein/Makefile > +++ b/drivers/staging/skein/Makefile > @@ -4,10 +4,10 @@ > subdir-ccflags-y := -I$(src)/include/ as part of the rearranging of files, I think you want to get rid of this include directory, move the files up to the main directory and include them as "skein.h" (rather than ). Then this line can be removed from the Makefile. > --- a/drivers/staging/skein/threefish1024Block.c > +++ b/drivers/staging/skein/threefish_1024_block.c > @@ -1,5 +1,5 @@ > #include > -#include > +#include incidentally, none of the threefish_*_block.c files actually needs linux/string.h ... there may be other files where that's true too, it seems to have just gotten added everywhere ... jake -- Jake Edge - LWN - jake@lwn.net - http://lwn.net