From: Christoph Hellwig <hch@infradead.org>
To: Jianyu Zhan <nasa4836@gmail.com>
Cc: Christoph Hellwig <hch@infradead.org>,
Jens Axboe <axboe@kernel.dk>, LKML <linux-kernel@vger.kernel.org>
Subject: Re: time to move fs/bio.c to block/ ?
Date: Mon, 19 May 2014 07:33:37 -0700 [thread overview]
Message-ID: <20140519143337.GB568@infradead.org> (raw)
In-Reply-To: <CAHz2CGUXwQ33VwSYQFkBXMUFR=nH_JDf0Chzaj5PUNDMj3Au3A@mail.gmail.com>
On Mon, May 19, 2014 at 10:28:16PM +0800, Jianyu Zhan wrote:
> Hi, Christoph, Jens,
>
> BTW, just out of curiosity, the VFS infrastructure code is just scatterd
> around the fs directory, which is quite suprised to a new comer that why
> there is "no" vfs stuff in fs directory. Does it make sense to also collect
> them into a dedicated sub-dir, maybe vfs. IMHO, this could make code
> skeleton more clear and could avoid such mis-sending patches in a long
> term maintainability view.
fs/*.[ch] shouldn't be much that isn't VFS in the broader sense
(including library functions). Besides the block files the only the only
things that might make sense to move out are binfmt*.c, signalfd.c
and timerfd.c (to kernel/ ?).
>
> Thanks,
> Jianyu Zhan
---end quoted text---
prev parent reply other threads:[~2014-05-19 14:33 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-19 14:13 Christoph Hellwig
2014-05-19 14:14 ` Jens Axboe
2014-05-19 14:25 ` Al Viro
2014-05-19 14:31 ` Christoph Hellwig
2014-05-19 14:31 ` Jens Axboe
2014-05-19 14:34 ` Christoph Hellwig
2014-05-19 14:38 ` Jens Axboe
2014-05-19 16:39 ` Al Viro
2014-05-19 16:58 ` Christoph Hellwig
2014-05-19 17:05 ` Jens Axboe
2014-05-20 0:28 ` Ming Lei
2014-05-20 2:00 ` Jens Axboe
2014-05-19 14:28 ` Jianyu Zhan
2014-05-19 14:33 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140519143337.GB568@infradead.org \
--to=hch@infradead.org \
--cc=axboe@kernel.dk \
--cc=linux-kernel@vger.kernel.org \
--cc=nasa4836@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®