From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752194AbaETLTJ (ORCPT ); Tue, 20 May 2014 07:19:09 -0400 Received: from 80-229-23-162.plus.com ([80.229.23.162]:40466 "EHLO mail.einon.net" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1750706AbaETLTI (ORCPT ); Tue, 20 May 2014 07:19:08 -0400 X-Greylist: delayed 554 seconds by postgrey-1.27 at vger.kernel.org; Tue, 20 May 2014 07:19:07 EDT Date: Tue, 20 May 2014 12:08:46 +0100 From: Mark Einon To: Peter Senna Tschudin Cc: kernel-janitors@vger.kernel.org, Greg Kroah-Hartman , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 5/8] staging: et131x: Remove useless return variables Message-ID: <20140520110845.GA4672@leicester.auvation.com> References: <1400582028-24990-5-git-send-email-peter.senna@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1400582028-24990-5-git-send-email-peter.senna@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 20, 2014 at 12:33:45PM +0200, Peter Senna Tschudin wrote: > This patch remove variables that are initialized with a constant, > are never updated, and are only used as parameter of return. > Return the constant instead of using a variable. > > Verified by compilation only. > > The coccinelle script that find and fixes this issue is: > // > @@ > type T; > constant C; > identifier ret; > @@ > - T ret = C; > ... when != ret > - return ret; > + return C; > // > > Signed-off-by: Peter Senna Tschudin Acked-by: Mark Einon