From: Jason Cooper <jason@lakedaemon.net>
To: Jake Edge <jake@lwn.net>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
Joe Perches <joe@perches.com>,
Dan Carpenter <dan.carpenter@oracle.com>,
Anton Saraev <antonysaraev@gmail.com>
Subject: Re: [PATCH 0/3] staging/skein: more cleanup
Date: Tue, 20 May 2014 13:47:07 -0400 [thread overview]
Message-ID: <20140520174707.GB8664@titan.lakedaemon.net> (raw)
In-Reply-To: <20140520102411.413d565d@chukar.edge2.net>
On Tue, May 20, 2014 at 10:24:11AM -0600, Jake Edge wrote:
> On Tue, 20 May 2014 10:47:57 -0400 Jason Cooper wrote:
>
> > Do you have any other series pending for this driver?
>
> No and I won't be doing anything else for the next couple of days --
> some darn weekly edition to deal with :)
:)
> It seems like most of the straightforward stuff has been dealt with at
> this point. That rats nest of ifdefs in skein_block.c needs attention,
> but some kind of tests are needed to ensure nothing breaks before
> digging into that ...
Something like objdiff [1]? It landed in v3.15-rc1, so you can use it
from staging/staging-next.
I'd also like to consolidate all the macros that are declared in the
middle of functions and such. After that, test vectors and crypto API
integration.
thx,
Jason.
[1] https://git.kernel.org/cgit/linux/kernel/git/gregkh/staging.git/commit/scripts/objdiff?id=79192ca8ebd9a25c583aa46024a250fef1e7766f
next prev parent reply other threads:[~2014-05-20 17:47 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-20 13:56 Jake Edge
2014-05-20 13:58 ` [PATCH 1/3] staging/skein: move all threefish block functions to one file Jake Edge
2014-05-20 14:00 ` [PATCH 2/3] staging/skein: comment typos Jake Edge
2014-05-20 14:02 ` [PATCH 3/3] staging/skein: variable/member name cleanup Jake Edge
2014-05-20 14:47 ` [PATCH 0/3] staging/skein: more cleanup Jason Cooper
2014-05-20 16:24 ` Jake Edge
2014-05-20 17:47 ` Jason Cooper [this message]
2014-05-20 21:52 ` Anton Saraev
2014-05-22 16:52 ` Jake Edge
2014-05-22 17:04 ` Jason Cooper
2014-05-24 14:50 ` Anton Saraev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140520174707.GB8664@titan.lakedaemon.net \
--to=jason@lakedaemon.net \
--cc=antonysaraev@gmail.com \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=jake@lwn.net \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®