From: Mark Brown <broonie@kernel.org>
To: Lars-Peter Clausen <lars@metafoo.de>
Cc: Tomasz Figa <tomasz.figa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>,
alsa-devel@alsa-project.org, Kukjin Kim <kgene.kim@samsung.com>,
Sangbeom Kim <sbkim73@samsung.com>,
linux-kernel@vger.kernel.org, Liam Girdwood <lgirdwood@gmail.com>,
Takashi Iwai <tiwai@suse.de>,
linux-samsung-soc@vger.kernel.org,
Ben Dooks <ben-linux@fluff.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [alsa-devel] [PATCH] Fix for possible null pointer dereference in dma.c
Date: Tue, 20 May 2014 22:58:54 +0100 [thread overview]
Message-ID: <20140520215854.GY12304@sirena.org.uk> (raw)
In-Reply-To: <537BC744.8020601@metafoo.de>
[-- Attachment #1: Type: text/plain, Size: 903 bytes --]
On Tue, May 20, 2014 at 11:21:08PM +0200, Lars-Peter Clausen wrote:
> On 05/20/2014 09:16 PM, Tomasz Figa wrote:
> >Still, I'm not too experienced with ALSA and ASoC, so I might be wrong.
> >Mark, what do you think about this?
> Given that there is a patch[1] which removes the whole file I think we can
> stop the discussion about this patch here.
> But for the record, substream will never ever be NULL in this function. prtd
> might be though if the DMA completion callback races against the closing of
> the PCM stream.
Yeah, what Lars said - obviously the patch removing the driver is more
comprehensive!
For the record it's very helpful to be specific about what the problem
being addressed is in the changelog, if it's not obvious what the bug
that's being fixed is that'll slow things down. Please also use subject
lines appropriate for the subsystem, it will help your patch get
noticed.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2014-05-20 21:59 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-15 21:57 Rickard Strandqvist
2014-05-19 5:39 ` Lothar Waßmann
2014-05-19 10:52 ` Tomasz Figa
2014-05-20 19:12 ` Rickard Strandqvist
2014-05-20 19:16 ` Tomasz Figa
2014-05-20 19:29 ` [alsa-devel] " Andrew Eikum
2014-05-20 19:31 ` Tomasz Figa
2014-05-20 21:21 ` Lars-Peter Clausen
2014-05-20 21:58 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140520215854.GY12304@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=ben-linux@fluff.org \
--cc=kgene.kim@samsung.com \
--cc=lars@metafoo.de \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=rickard_strandqvist@spectrumdigital.se \
--cc=sbkim73@samsung.com \
--cc=tiwai@suse.de \
--cc=tomasz.figa@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®