From: David Miller <davem@davemloft.net>
To: cwang@twopensource.com
Cc: milos.vyletel@gmail.com, kuznet@ms2.inr.ac.ru, jmorris@namei.org,
yoshfuji@linux-ipv6.org, kaber@trash.net, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [patch net-next] net: ipv6: trigger action when setting conf.all sysctls
Date: Wed, 21 May 2014 16:31:13 -0400 (EDT) [thread overview]
Message-ID: <20140521.163113.383854871907102866.davem@davemloft.net> (raw)
In-Reply-To: <CAHA+R7PaM4c6TmUtTLDAGnBUmRKE7=vnsjm67i=rmNebZvacVw@mail.gmail.com>
From: Cong Wang <cwang@twopensource.com>
Date: Wed, 21 May 2014 10:35:17 -0700
> On Mon, May 19, 2014 at 10:09 AM, Milos Vyletel <milos.vyletel@gmail.com> wrote:
>> As it is right now most of these tunables don't do anything - they don't
>> set any interface specific settings to the desired value and they don't
>> take precedence before device specific settings in most cases.
>>
>> Documentation/networking/ip-sysctl.txt defines them to be:
>> conf/all/*:
>> Change all the interface-specific settings.
>>
>> but that is not really the case.
>>
>
> I don't think it's a good idea, it enforces interface specific changes.
>
> You need to mimic what IPv4 conf does (if it hasn't done yet), something
> like below:
>
> #define IN_DEV_MAXCONF(in_dev, attr) \
> (max(IPV4_DEVCONF_ALL(dev_net(in_dev->dev), attr), \
> IN_DEV_CONF_GET((in_dev), attr)))
Agreed.
next prev parent reply other threads:[~2014-05-21 20:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-19 17:09 Milos Vyletel
2014-05-21 17:35 ` Cong Wang
2014-05-21 20:31 ` David Miller [this message]
2014-05-28 17:45 ` Milos Vyletel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140521.163113.383854871907102866.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=cwang@twopensource.com \
--cc=jmorris@namei.org \
--cc=kaber@trash.net \
--cc=kuznet@ms2.inr.ac.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=milos.vyletel@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®