From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751913AbaEVSYB (ORCPT ); Thu, 22 May 2014 14:24:01 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:59033 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751424AbaEVSX7 (ORCPT ); Thu, 22 May 2014 14:23:59 -0400 Date: Thu, 22 May 2014 11:23:57 -0700 From: Andrew Morton To: Vlastimil Babka Cc: Mel Gorman , Joonsoo Kim , Johannes Weiner , Jan Kara , Michal Hocko , Hugh Dickins , Peter Zijlstra , Dave Hansen , Linux Kernel , Linux-MM , Linux-FSDevel Subject: Re: [PATCH 09/19] mm: page_alloc: Use word-based accesses for get/set pageblock bitmaps Message-Id: <20140522112357.4715059bb69273f40c3ec4f2@linux-foundation.org> In-Reply-To: <537DC247.5020801@suse.cz> References: <1399974350-11089-1-git-send-email-mgorman@suse.de> <1399974350-11089-10-git-send-email-mgorman@suse.de> <537DC247.5020801@suse.cz> X-Mailer: Sylpheed 3.2.0beta5 (GTK+ 2.24.10; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 22 May 2014 11:24:23 +0200 Vlastimil Babka wrote: > > In a test running dd onto tmpfs the overhead of the pageblock-related > > functions went from 1.27% in profiles to 0.5%. > > > > Signed-off-by: Mel Gorman > > Acked-by: Vlastimil Babka > > Hi, I've tested if this closes the race I've been previously trying to fix > with the series in http://marc.info/?l=linux-mm&m=139359694028925&w=2 > And indeed with this patch I wasn't able to reproduce it in my stress test > (which adds lots of memory isolation calls) anymore. So thanks to Mel I can > dump my series in the trashcan :P > > Therefore I believe something like below should be added to the changelog, > and put to stable as well. OK, I made it so. Miraculously, the patch applies OK to 3.14. And it compiles!