From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751456AbaEWUNE (ORCPT ); Fri, 23 May 2014 16:13:04 -0400 Received: from shards.monkeyblade.net ([149.20.54.216]:55374 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751106AbaEWUNC (ORCPT ); Fri, 23 May 2014 16:13:02 -0400 Date: Fri, 23 May 2014 16:09:45 -0400 (EDT) Message-Id: <20140523.160945.226886017757584215.davem@davemloft.net> To: Wei.Yang@windriver.com Cc: peppe.cavallaro@st.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1] net: driver: stmicro: Remove some useless the lock protection From: David Miller In-Reply-To: <1400843103-19433-1-git-send-email-Wei.Yang@windriver.com> References: <1400843103-19433-1-git-send-email-Wei.Yang@windriver.com> X-Mailer: Mew version 6.5 on Emacs 24.1 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.7 (shards.monkeyblade.net [149.20.54.216]); Fri, 23 May 2014 13:13:01 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Date: Fri, 23 May 2014 19:05:03 +0800 > From: Yang Wei > > kernel always invokes a pair of rtnl_lock adn rtnl_unlock to > protect dev_ethtool(), so its not neccessary to invoke spin_lock/unlock > in ethtool_ops. > > Signed-off-by: Yang Wei This does not apply cleanly to the net-next tree, please respin.