From: David Miller <davem@davemloft.net>
To: joe@perches.com
Cc: manuel.schoelling@gmx.de, kevin.curtis@farsite.co.uk,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] wan: time_before()
Date: Mon, 26 May 2014 00:40:45 -0400 (EDT) [thread overview]
Message-ID: <20140526.004045.1779020170437806699.davem@davemloft.net> (raw)
In-Reply-To: <1401040732.22191.8.camel@joe-AO725>
From: Joe Perches <joe@perches.com>
Date: Sun, 25 May 2014 10:58:52 -0700
> On Sun, 2014-05-25 at 19:32 +0200, Manuel Schölling wrote:
>> To be future-proof and for better readability the time comparisons are
>> modified to use time_before() instead of plain, error-prone math.
>
> Sensible change, but it seems these should be
> udelay(some_constant) instead of a a rather
> variable time wait based on a system/config
> defined jiffies.
Agreed, this code probably wants udelay(10) or something like
that.
next prev parent reply other threads:[~2014-05-26 4:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-25 17:32 Manuel Schölling
2014-05-25 17:58 ` Joe Perches
2014-05-26 4:40 ` David Miller [this message]
2014-05-28 7:09 ` Kevin Curtis
2014-05-31 15:07 ` [PATCH] wan: Use usleep_range() Manuel Schölling
2014-06-02 8:56 ` Kevin Curtis
2014-06-03 0:01 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140526.004045.1779020170437806699.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=joe@perches.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kevin.curtis@farsite.co.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=manuel.schoelling@gmx.de \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®