mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Daeseok Youn <daeseok.youn@gmail.com>
To: lidza.louina@gmail.com, gregkh@linuxfoundation.org
Cc: markh@compro.net, driverdev-devel@linuxdriverproject.org,
	devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: [PATCH 1/4] staging: dgap: remove unneeded kfree() for ttys in tty_driver
Date: Mon, 26 May 2014 19:23:01 +0900	[thread overview]
Message-ID: <20140526102301.GA13785@devel.8.8.4.4> (raw)

In destruct_tty_driver() from put_tty_driver() will free the
ttys in tty_driver.

Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com>
---
 drivers/staging/dgap/dgap.c |    4 ----
 1 files changed, 0 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap/dgap.c
index 1475532..60b7d70 100644
--- a/drivers/staging/dgap/dgap.c
+++ b/drivers/staging/dgap/dgap.c
@@ -1503,8 +1503,6 @@ static void dgap_tty_uninit(struct board_t *brd)
 			tty_unregister_device(brd->serial_driver, i);
 		}
 		tty_unregister_driver(brd->serial_driver);
-		kfree(brd->serial_driver->ttys);
-		brd->serial_driver->ttys = NULL;
 		put_tty_driver(brd->serial_driver);
 		kfree(brd->serial_ports);
 		brd->dgap_major_serial_registered = FALSE;
@@ -1520,8 +1518,6 @@ static void dgap_tty_uninit(struct board_t *brd)
 			tty_unregister_device(brd->print_driver, i);
 		}
 		tty_unregister_driver(brd->print_driver);
-		kfree(brd->print_driver->ttys);
-		brd->print_driver->ttys = NULL;
 		put_tty_driver(brd->print_driver);
 		kfree(brd->printer_ports);
 		brd->dgap_major_transparent_print_registered = FALSE;
-- 
1.7.1


                 reply	other threads:[~2014-05-26 10:23 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140526102301.GA13785@devel.8.8.4.4 \
    --to=daeseok.youn@gmail.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=driverdev-devel@linuxdriverproject.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=lidza.louina@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=markh@compro.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®