From: Mark Brown <broonie@kernel.org>
To: Philipp Zabel <p.zabel@pengutronix.de>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org, kernel@pengutronix.de
Subject: Re: [PATCH v2] regmap: mmio: Fix regmap_mmio_write for uneven counts
Date: Mon, 26 May 2014 16:56:16 +0100 [thread overview]
Message-ID: <20140526155616.GD22111@sirena.org.uk> (raw)
In-Reply-To: <1400250334-9397-1-git-send-email-p.zabel@pengutronix.de>
[-- Attachment #1: Type: text/plain, Size: 461 bytes --]
On Fri, May 16, 2014 at 04:25:34PM +0200, Philipp Zabel wrote:
> Commit 932580409a9dacbf42215fa737bf06ae2c0aa624
> "regmap: mmio: Add support for 1/2/8 bytes wide register address."
> broke regmap_mmio_write for uneven counts, for example 32-bit register
> addresses with no padding and 8-byte values (count = 5).
> Fix this by allowing all counts large enough to include some value.
> This check was BUG_ON(count < 4) before the last change.
Applied, thanks.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2014-05-26 15:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-16 14:25 Philipp Zabel
2014-05-26 15:56 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140526155616.GD22111@sirena.org.uk \
--to=broonie@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=kernel@pengutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®