From: Wim Van Sebroeck <wim@iguana.be>
To: Per Gundberg <per.gundberg@icomera.com>
Cc: linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] watchdog: kempld-wdt: Use the correct value when configuring the prescaler with the watchdog
Date: Mon, 26 May 2014 20:59:59 +0200 [thread overview]
Message-ID: <20140526185959.GA21481@spo001.leaseweb.com> (raw)
In-Reply-To: <CAKUdnSzO2ixCOvvxAwz3duXsPEpExVND7VA_DVPAYpwQGTwYdQ@mail.gmail.com>
Hi Per,
> Use the prescaler index, rather than its value, to configure the watchdog.
> This will prevent a mismatch with the prescaler used to calculate the
> cycles.
>
> Signed-off-by: Per Gundberg <per.gundberg@icomera.com>
> ---
> drivers/watchdog/kempld_wdt.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- src/drivers/watchdog/kempld_wdt.c.orig 2014-04-24 07:32:08.463745055
> +0000
> +++ src/drivers/watchdog/kempld_wdt.c 2014-04-24 07:34:09.839739808 +0000
> @@ -163,7 +163,7 @@ static int kempld_wdt_set_stage_timeout(
> kempld_get_mutex(pld);
> stage_cfg = kempld_read8(pld, KEMPLD_WDT_STAGE_CFG(stage->id));
> stage_cfg &= ~STAGE_CFG_PRESCALER_MASK;
> - stage_cfg |= STAGE_CFG_SET_PRESCALER(prescaler);
> + stage_cfg |= STAGE_CFG_SET_PRESCALER(PRESCALER_21);
> kempld_write8(pld, KEMPLD_WDT_STAGE_CFG(stage->id), stage_cfg);
> kempld_write32(pld, KEMPLD_WDT_STAGE_TIMEOUT(stage->id),
> stage_timeout);
This patch has been added to linux-watchdog-next.
Kind regards,
Wim.
next parent reply other threads:[~2014-05-26 19:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CAKUdnSzO2ixCOvvxAwz3duXsPEpExVND7VA_DVPAYpwQGTwYdQ@mail.gmail.com>
2014-05-26 18:59 ` Wim Van Sebroeck [this message]
2014-04-24 13:49 gundberg
2014-04-24 15:15 ` Guenter Roeck
2014-05-07 20:19 ` Michael Brunner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140526185959.GA21481@spo001.leaseweb.com \
--to=wim@iguana.be \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=per.gundberg@icomera.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®