From: Grant Likely <grant.likely@linaro.org>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
Daniel Mack <zonque@gmail.com>, Rob Herring <robh+dt@kernel.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] of: handle NULL node in of_get_next_available_child
Date: Tue, 27 May 2014 21:17:11 +0100 [thread overview]
Message-ID: <20140527201711.553B8C40BD2@trevor.secretlab.ca> (raw)
In-Reply-To: <CAGVrzcYKCGXbOR1FRaOLxjPeaFEq6skgUvG_i4nqGSdJBUZRqQ@mail.gmail.com>
On Tue, 27 May 2014 10:36:10 -0700, Florian Fainelli <f.fainelli@gmail.com> wrote:
> Hi Grant,
>
> 2014-05-27 4:19 GMT-07:00 Grant Likely <grant.likely@linaro.org>:
> > On Fri, 23 May 2014 12:43:11 -0700, Florian Fainelli <f.fainelli@gmail.com> wrote:
> >> Add an early check for the node argument in
> >> of_get_next_available_child() to avoid dereferencing a NULL node pointer
> >> a few lines after.
> >>
> >> CC: Daniel Mack <zonque@gmail.com>
> >> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
> >
> > Is there a bug that exposed this path?
>
> Daniel sent a patch recently [1] which makes us call
> for_each_available_child_of_node() on a potentially NULL node
> argument.
And yet in your reply to that patch you argued that the NULL check
should be in the caller!
Anyway, this isn't a big deal. Post a patch fixing both and I'll apply
it.
g.
prev parent reply other threads:[~2014-05-27 20:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-23 19:43 Florian Fainelli
2014-05-27 11:19 ` Grant Likely
2014-05-27 17:36 ` Florian Fainelli
2014-05-27 20:17 ` Grant Likely [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140527201711.553B8C40BD2@trevor.secretlab.ca \
--to=grant.likely@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=zonque@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®