mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Marcin Kostrzewa <marckostrzewa@gmail.com>
Cc: Ian Abbott <abbotti@mev.co.uk>,
	H Hartley Sweeten <hsweeten@visionengravers.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Fred Akers <knivey@botops.net>,
	devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] remove duplicated comment and fix brace placement in drivers/staging/comedi/drivers/addi-data/hwdrv_acpi3501.c
Date: Wed, 28 May 2014 00:24:24 +0300	[thread overview]
Message-ID: <20140527212424.GS15585@mwanda> (raw)
In-Reply-To: <1401200257-790-1-git-send-email-marckostrzewa@gmail.com>

The subject should be:

[PATCH] Staging: comedi: addi-data: <short title. clean up else statement>



On Tue, May 27, 2014 at 02:17:35PM +0000, Marcin Kostrzewa wrote:
> Signed-off-by: Marcin Kostrzewa <marckostrzewa@gmail.com>
> ---
>  drivers/staging/comedi/drivers/addi-data/hwdrv_apci3501.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/comedi/drivers/addi-data/hwdrv_apci3501.c b/drivers/staging/comedi/drivers/addi-data/hwdrv_apci3501.c
> index 20e89b0..8add8d8 100644
> --- a/drivers/staging/comedi/drivers/addi-data/hwdrv_apci3501.c
> +++ b/drivers/staging/comedi/drivers/addi-data/hwdrv_apci3501.c
> @@ -104,9 +104,7 @@ static int apci3501_write_insn_timer(struct comedi_device *dev,
>  			outl(ul_Command1, dev->iobase + APCI3501_TIMER_CTRL_REG);
>  		}
>  
> -		else if (data[1] == 0)	/* Stop The Watchdog */
> -		{
> -			/* Stop The Watchdog */
> +		else if (data[1] == 0) { /* Stop The Watchdog */


While you're at it, could you also move it like this:

		} else if (data[1] == 0) { /* Stop The Watchdog */

(I wouldn't have asked you to do this, except that you need to resend
anyway with a fixed subject line).

regards,
dan carpenter

>  			ul_Command1 = inl(dev->iobase + APCI3501_TIMER_CTRL_REG);
>  			ul_Command1 = ul_Command1 & 0xFFFFF9FEUL;
>  			outl(0x0, dev->iobase + APCI3501_TIMER_CTRL_REG);
> -- 
> 1.9.2
> 
> _______________________________________________
> devel mailing list
> devel@linuxdriverproject.org
> http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

      reply	other threads:[~2014-05-27 21:24 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-27 14:17 Marcin Kostrzewa
2014-05-27 21:24 ` Dan Carpenter [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140527212424.GS15585@mwanda \
    --to=dan.carpenter@oracle.com \
    --cc=abbotti@mev.co.uk \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=hsweeten@visionengravers.com \
    --cc=knivey@botops.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marckostrzewa@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome