From: Steven Rostedt <rostedt@goodmis.org>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Stephen Boyd <sboyd@codeaurora.org>,
Arnd Bergmann <arnd@arndb.de>,
Frederic Weisbecker <fweisbec@gmail.com>,
Ingo Molnar <mingo@redhat.com>,
linux-kernel@vger.kernel.org, Corey Minyard <cminyard@mvista.com>,
Stanislav Meduna <stano@meduna.org>,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
rjw@rjwysocki.net
Subject: Re: [PATCH v2] tracing: Don't account for cpu idle time with irqsoff tracers
Date: Wed, 28 May 2014 10:09:10 -0400 [thread overview]
Message-ID: <20140528100910.6035ea7d@gandalf.local.home> (raw)
In-Reply-To: <20140528072852.GN11096@twins.programming.kicks-ass.net>
On Wed, 28 May 2014 09:28:52 +0200
Peter Zijlstra <peterz@infradead.org> wrote:
> On Tue, May 27, 2014 at 07:30:50PM -0400, Steven Rostedt wrote:
> > Paul, Peter, see anything wrong with this?
>
> You mean, aside from that it won't actually apply due to that code
> having been massively overhauled?
>
> I suppose the same thing Arnd mentioned, the cpuidle_enter() thing can
> be huge, but is we're going to have to push this down into all cpuidle
> drivers we're not going to be happy.
>
I believe that the stop/start_critical_timings() can nest. If not, I
can make them do so. Thus, we could start adding them in the depths of
the cpuidle drivers. If we miss one, we may not notice until someone
reports a large latency due to it. And that is only if the driver
itself calls local_irq_save/restore().
-- Steve
prev parent reply other threads:[~2014-05-28 14:09 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-27 20:08 Stephen Boyd
2014-05-27 20:11 ` Arnd Bergmann
2014-05-27 21:48 ` Steven Rostedt
2014-05-27 22:21 ` Stephen Boyd
2014-05-27 23:30 ` Steven Rostedt
2014-05-28 0:11 ` Stephen Boyd
2014-05-28 0:23 ` Stephen Boyd
2014-05-28 0:42 ` Steven Rostedt
2014-05-28 7:24 ` Peter Zijlstra
2014-05-28 17:22 ` John Stultz
2014-05-28 0:25 ` Paul E. McKenney
2014-05-28 6:40 ` Arnd Bergmann
2014-05-28 6:44 ` Arnd Bergmann
2014-05-28 7:28 ` Peter Zijlstra
2014-05-28 14:09 ` Steven Rostedt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140528100910.6035ea7d@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=arnd@arndb.de \
--cc=cminyard@mvista.com \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=paulmck@linux.vnet.ibm.com \
--cc=peterz@infradead.org \
--cc=rjw@rjwysocki.net \
--cc=sboyd@codeaurora.org \
--cc=stano@meduna.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®