From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932182AbaE1PTO (ORCPT ); Wed, 28 May 2014 11:19:14 -0400 Received: from gw-1.arm.linux.org.uk ([78.32.30.217]:37117 "EHLO pandora.arm.linux.org.uk" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754680AbaE1PTM (ORCPT ); Wed, 28 May 2014 11:19:12 -0400 Date: Wed, 28 May 2014 16:17:39 +0100 From: Russell King - ARM Linux To: James Bottomley Cc: Christoph Hellwig , Paul Bolle , linux-arm-kernel@lists.infradead.org, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] acornscsi: remove linked command support Message-ID: <20140528151739.GJ3693@n2100.arm.linux.org.uk> References: <1400926433.31526.89.camel@x220> <20140528104114.GE13542@infradead.org> <1401287204.2288.28.camel@dabdike> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1401287204.2288.28.camel@dabdike> User-Agent: Mutt/1.5.19 (2009-01-05) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 28, 2014 at 06:26:44PM +0400, James Bottomley wrote: > On Wed, 2014-05-28 at 03:41 -0700, Christoph Hellwig wrote: > > Looks good, > > > > Reviewed-by: Christoph Hellwig > > > > And I have to disagree with James here, removing code that isn't even > > compiled always is an improvement, especially for an unmaintained > > driver. > > Well, as I said, this is in theory a maintained driver, so just get an > ack from Russell and this debate is moot. I don't see any harm in removing this - I don't think I've owned any SCSI devices which supported linked commands, which is why I never put much effort into it. As no one else seems to care about it (given the number of years it's been left alone), removing the linked command stuff is fine. Acked-by: Russell King -- FTTC broadband for 0.8mile line: now at 9.7Mbps down 460kbps up... slowly improving, and getting towards what was expected from it.