From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755920AbaE2Tmc (ORCPT ); Thu, 29 May 2014 15:42:32 -0400 Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:59344 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754049AbaE2Tmb (ORCPT ); Thu, 29 May 2014 15:42:31 -0400 Date: Thu, 29 May 2014 21:42:23 +0200 From: Pavel Machek To: Tony Lindgren Cc: Paul Bolle , Russell King , linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ARM: OMAP: SX1: remove check for CONFIG_SX1_OLD_FLASH Message-ID: <20140529194223.GA20722@amd.pavel.ucw.cz> References: <1400182902.11786.21.camel@x220> <20140516211231.GF12881@atomide.com> <20140529190227.GB18230@amd.pavel.ucw.cz> <20140529191738.GA18567@atomide.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20140529191738.GA18567@atomide.com> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu 2014-05-29 12:17:39, Tony Lindgren wrote: > * Pavel Machek [140529 12:03]: > > On Fri 2014-05-16 14:12:31, Tony Lindgren wrote: > > > * Paul Bolle [140515 12:42]: > > > > A check for CONFIG_SX1_OLD_FLASH was added in v2.6.24. But the related > > > > Kconfig symbol was never part of the tree. So we can remove some dead > > > > code. > > > > > > Thanks applying into omap-for-v3.16/board. > > > > Actually... It seems there are two variant of SX1, and this is very > > useful piece of documentation how the _other_ variant looks. > > > > And if someone is hacking linux on sx1, he can probably figure out > > #ifdef in .c file... > > > > IOW adding the config option might be better solution. > > Or just a comment saying the same? Yes, #if 0 with a comment would do the same trick. Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html