From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754066AbaE3AmI (ORCPT ); Thu, 29 May 2014 20:42:08 -0400 Received: from lgeamrelo04.lge.com ([156.147.1.127]:47485 "EHLO lgeamrelo04.lge.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753403AbaE3AmG (ORCPT ); Thu, 29 May 2014 20:42:06 -0400 X-Original-SENDERIP: 10.177.220.145 X-Original-MAILFROM: iamjoonsoo.kim@lge.com Date: Fri, 30 May 2014 09:45:14 +0900 From: Joonsoo Kim To: Gioh Kim Cc: Andrew Morton , Rik van Riel , Johannes Weiner , Mel Gorman , Laura Abbott , Minchan Kim , Heesub Shin , Marek Szyprowski , Michal Nazarewicz , "Aneesh Kumar K.V" , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 2/3] CMA: aggressively allocate the pages on cma reserved memory when not used Message-ID: <20140530004514.GB8906@js1304-P5Q-DELUXE> References: <1401260672-28339-1-git-send-email-iamjoonsoo.kim@lge.com> <1401260672-28339-3-git-send-email-iamjoonsoo.kim@lge.com> <5386E0CA.5040201@lge.com> <20140529074847.GA7554@js1304-P5Q-DELUXE> <5386EB3E.5090007@lge.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5386EB3E.5090007@lge.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 29, 2014 at 05:09:34PM +0900, Gioh Kim wrote: > > >>>+ > >>> /* > >>> * Do the hard work of removing an element from the buddy allocator. > >>> * Call me with the zone->lock already held. > >>>@@ -1143,10 +1223,15 @@ __rmqueue_fallback(struct zone *zone, int order, int start_migratetype) > >>> static struct page *__rmqueue(struct zone *zone, unsigned int order, > >>> int migratetype) > >>> { > >>>- struct page *page; > >>>+ struct page *page = NULL; > >>>+ > >>>+ if (IS_ENABLED(CONFIG_CMA) && > >> > >>You might know that CONFIG_CMA is enabled and there is no CMA memory, because CONFIG_CMA_SIZE_MBYTES can be zero. > >>Is IS_ENABLED(CONFIG_CMA) alright in that case? > > > >next line checks whether zone->managed_cma_pages is positive or not. > >If there is no CMA memory, zone->managed_cma_pages will be zero and > >we will skip to call __rmqueue_cma(). > > Is IS_ENABLED(CONFIG_CMA) necessary? > What about if (migratetype == MIGRATE_MOVABLE && zone->managed_cma_pages) ? Yes, field, managed_cma_pages exists only if CONFIG_CMA is enabled, so removing IS_ENABLE(CONFIG_CMA) would break the build. Thanks.