From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932311AbaE3GIO (ORCPT ); Fri, 30 May 2014 02:08:14 -0400 Received: from kirsty.vergenet.net ([202.4.237.240]:56164 "EHLO kirsty.vergenet.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932093AbaE3GIN (ORCPT ); Fri, 30 May 2014 02:08:13 -0400 Date: Fri, 30 May 2014 15:08:10 +0900 From: Simon Horman To: Dave Young Cc: matt.fleming@intel.com, bp@alien8.de, linux-kernel@vger.kernel.org, linux-efi@vger.kernel.org, vgoyal@redhat.com Subject: Re: [PATCH]x86 efi: do not export efi runtime map in case old map Message-ID: <20140530060810.GA31868@verge.net.au> References: <20140530032010.GA29906@dhcp-16-198.nay.redhat.com> <20140530055447.GB2187@darkstar.nay.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20140530055447.GB2187@darkstar.nay.redhat.com> Organisation: Horms Solutions Ltd. User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 30, 2014 at 01:54:47PM +0800, Dave Young wrote: > Ccing Simon. > > Simon, appologize for not ccing you about this kernel patch. I see you have > applied the userspace patch for checking sysfs runtime existance. > > The userspace patch depends on this patch but it is not harmful even without > this kernel patch. So applying the userspace patch before this one is still > safe. Thanks, I understand. If the kernel side ends up being rejected or modified please send an update for kexec-tools accordingly. > > On 05/30/14 at 11:20am, Dave Young wrote: > > > > For ioremapped efi memory aka old_map the virt addresses are not persistant > > across kexec reboot. kexec-tools will read the runtime maps from sysfs then > > pass them to 2nd kernel and assuming kexec efi boot is ok. This will cause > > kexec boot failure. > > > > To address this issue do not export runtime maps in case efi old_map so > > userspace can use no efi boot instead. > > > > Signed-off-by: Dave Young > > --- > > arch/x86/platform/efi/efi.c | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/arch/x86/platform/efi/efi.c b/arch/x86/platform/efi/efi.c > > index 3781dd3..4d36932 100644 > > --- a/arch/x86/platform/efi/efi.c > > +++ b/arch/x86/platform/efi/efi.c > > @@ -919,6 +919,9 @@ static void __init save_runtime_map(void) > > void *tmp, *p, *q = NULL; > > int count = 0; > > > > + if (efi_enabled(EFI_OLD_MEMMAP)) > > + return; > > + > > for (p = memmap.map; p < memmap.map_end; p += memmap.desc_size) { > > md = p; > > > > -- > > 1.8.3.1 > > > > -- > > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > > the body of a message to majordomo@vger.kernel.org > > More majordomo info at http://vger.kernel.org/majordomo-info.html > > Please read the FAQ at http://www.tux.org/lkml/ >