From: Stephen Rothwell <sfr@canb.auug.org.au>
To: abdoulaye berthe <berthe.ab@gmail.com>
Cc: linus.walleij@linaro.org, gnurou@gmail.com,
mika.westerberg@linux.intel.com,
andriy.shevchenko@linux.intel.com, linux-gpio@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] gpio: gpiolib: set gpiochip_remove retval to void
Date: Fri, 30 May 2014 08:58:32 +1000 [thread overview]
Message-ID: <20140530085832.711df1c6@canb.auug.org.au> (raw)
In-Reply-To: <1401402722-26631-1-git-send-email-berthe.ab@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 418 bytes --]
Hi abdoulaye,
On Fri, 30 May 2014 00:32:02 +0200 abdoulaye berthe <berthe.ab@gmail.com> wrote:
>
> + if (test_bit(FLAG_REQUESTED, &chip->desc[id].flags))
> + panic("gpio: removing gpiochip with gpios still requested\n");
Someone else already commented that panic is probably overkill ... is
there no way to log this and continue?
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2014-05-29 22:58 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-23 17:03 abdoulaye berthe
2014-05-27 13:33 ` Linus Walleij
2014-05-29 22:32 ` abdoulaye berthe
2014-05-29 22:58 ` Stephen Rothwell [this message]
2014-05-23 17:12 abdoulaye berthe
2014-05-23 17:39 ` abdoulaye berthe
2014-05-25 7:46 ` Alexandre Courbot
2014-05-25 16:40 ` abdoulaye berthe
2014-05-25 23:47 ` Alexandre Courbot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140530085832.711df1c6@canb.auug.org.au \
--to=sfr@canb.auug.org.au \
--cc=andriy.shevchenko@linux.intel.com \
--cc=berthe.ab@gmail.com \
--cc=gnurou@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®