From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: mathieu.poirier@linaro.org
Cc: linus.walleij@linaro.org, will.deacon@arm.com, arve@android.com,
john.stultz@linaro.org, pratikp@codeaurora.org, varshney@ti.com,
Al.Grant@arm.com, jonas.svennebring@avagotech.com,
james.king@linaro.org, panchaxari.prasannamurthy@linaro.org,
arnd@linaro.org, marcin.jabrzyk@gmail.com,
r.sengupta@samsung.com, robbelibobban@gmail.com,
patches@linaro.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, daniel.thompson@linaro.org
Subject: Re: [RFC PATCH 04/11] coresight: add CoreSight ETB driver
Date: Fri, 30 May 2014 14:53:22 +0100 [thread overview]
Message-ID: <20140530135321.GQ3693@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <1401457391-12242-5-git-send-email-mathieu.poirier@linaro.org>
NAK for all the reasons I mentioned in the previous submission in 2012.
You partially did the right thing - you read through the previous
submission, and you said in your cover message that you had addressed
some of the comments from that submission.
What I find extremely distasteful is that you seem to have chosen to
completely ignore my comments - you haven't mentioned them in your
covering message at all, and you've just gone ahead and converted ETM
and ETB to be platform devices.
That gets you a NAK for that change, because you have done nothing what
so ever to address the concerns I raised.
Since you seem to have ignored my comments, this is as far as I'm looking
at your submission, and you can consider the entire submission NAK'd by
me.
Thanks.
--
FTTC broadband for 0.8mile line: now at 9.7Mbps down 460kbps up... slowly
improving, and getting towards what was expected from it.
next prev parent reply other threads:[~2014-05-30 13:55 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-30 13:43 [RFC PATCH 00/11] CoreSight framework and drivers mathieu.poirier
2014-05-30 13:43 ` [RFC PATCH 01/11] coresight: add CoreSight core layer framework mathieu.poirier
2014-05-30 17:25 ` Rob Herring
2014-05-30 18:02 ` Mathieu Poirier
2014-05-30 13:43 ` [RFC PATCH 02/11] coresight: add CoreSight TMC driver mathieu.poirier
2014-06-03 9:09 ` Linus Walleij
2014-06-16 23:12 ` Mathieu Poirier
2014-07-07 10:53 ` Linus Walleij
2014-05-30 13:43 ` [RFC PATCH 03/11] coresight: add CoreSight TPIU driver mathieu.poirier
2014-05-30 13:43 ` [RFC PATCH 04/11] coresight: add CoreSight ETB driver mathieu.poirier
2014-05-30 13:53 ` Russell King - ARM Linux [this message]
2014-05-30 16:28 ` Mathieu Poirier
2014-05-30 13:43 ` [RFC PATCH 05/11] coresight: add CoreSight Funnel driver mathieu.poirier
2014-05-30 13:43 ` [RFC PATCH 06/11] coresight: add CoreSight Replicator driver mathieu.poirier
2014-05-30 13:43 ` [RFC PATCH 07/11] coresight: add CoreSight ETM driver mathieu.poirier
2014-06-03 10:26 ` Daniel Thompson
2014-06-03 16:37 ` Mathieu Poirier
2014-06-03 17:04 ` Daniel Thompson
2014-05-30 13:43 ` [RFC PATCH 08/11] coresight: adding support for beagle board mathieu.poirier
2014-05-30 13:43 ` [RFC PATCH 09/11] coresight: adding basic support for Vexpress TC2 mathieu.poirier
2014-05-30 13:43 ` [RFC PATCH 10/11] coresight: adding support for beagleXM mathieu.poirier
2014-05-30 13:43 ` [RFC PATCH 11/11] ARM: moving support for etb/etm to the "drivers" directory mathieu.poirier
2014-05-30 13:49 ` Russell King - ARM Linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140530135321.GQ3693@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=Al.Grant@arm.com \
--cc=arnd@linaro.org \
--cc=arve@android.com \
--cc=daniel.thompson@linaro.org \
--cc=james.king@linaro.org \
--cc=john.stultz@linaro.org \
--cc=jonas.svennebring@avagotech.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcin.jabrzyk@gmail.com \
--cc=mathieu.poirier@linaro.org \
--cc=panchaxari.prasannamurthy@linaro.org \
--cc=patches@linaro.org \
--cc=pratikp@codeaurora.org \
--cc=r.sengupta@samsung.com \
--cc=robbelibobban@gmail.com \
--cc=varshney@ti.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®