From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933669AbaE3PhY (ORCPT ); Fri, 30 May 2014 11:37:24 -0400 Received: from mail-qg0-f46.google.com ([209.85.192.46]:45244 "EHLO mail-qg0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932378AbaE3PhW (ORCPT ); Fri, 30 May 2014 11:37:22 -0400 Date: Fri, 30 May 2014 11:37:18 -0400 From: Tejun Heo To: Paolo Valente Cc: Jens Axboe , Li Zefan , Fabio Checconi , Arianna Avanzini , Paolo Valente , linux-kernel@vger.kernel.org, containers@lists.linux-foundation.org, cgroups@vger.kernel.org Subject: Re: [PATCH RFC - TAKE TWO - 02/12] block, bfq: add full hierarchical scheduling and cgroups support Message-ID: <20140530153718.GB24871@htj.dyndns.org> References: <20140528221929.GG1419@htj.dyndns.org> <1401354343-5527-1-git-send-email-paolo.valente@unimore.it> <1401354343-5527-3-git-send-email-paolo.valente@unimore.it> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1401354343-5527-3-git-send-email-paolo.valente@unimore.it> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 29, 2014 at 11:05:33AM +0200, Paolo Valente wrote: > diff --git a/include/linux/cgroup_subsys.h b/include/linux/cgroup_subsys.h > index 768fe44..cdd2528 100644 > --- a/include/linux/cgroup_subsys.h > +++ b/include/linux/cgroup_subsys.h > @@ -39,6 +39,10 @@ SUBSYS(net_cls) > SUBSYS(blkio) > #endif > > +#if IS_ENABLED(CONFIG_CGROUP_BFQIO) > +SUBSYS(bfqio) > +#endif So, ummm, I don't think this is a good idea. Why aren't you plugging into the blkcg infrastructure as cfq does? Why does it need to be a separate controller? Thanks. -- tejun