From: Kamil Iskra <iskra@mcs.anl.gov>
To: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
Cc: <tony.luck@gmail.com>, <linux-kernel@vger.kernel.org>,
<linux-mm@kvack.org>, Andi Kleen <andi@firstfloor.org>,
Borislav Petkov <bp@suse.de>, <gong.chen@linux.jf.intel.com>
Subject: Re: [PATCH] mm/memory-failure.c: support dedicated thread to handle SIGBUS(BUS_MCEERR_AO) thread
Date: Fri, 30 May 2014 14:52:08 -0500 [thread overview]
Message-ID: <20140530195208.GB4067@mcs.anl.gov> (raw)
In-Reply-To: <1401327939-cvm7qh0m@n-horiguchi@ah.jp.nec.com>
On Wed, May 28, 2014 at 21:45:41 -0400, Naoya Horiguchi wrote:
> > The user could also mark more than
> > one thread in this way - in which case the kernel will pick
> > the first one it sees (is that oldest, or newest?) that is marked.
> > Not sure if this would ever be useful unless you want to pass
> > responsibility around in an application that is dynamically
> > creating and removing threads.
>
> I'm not sure which is better to send signal to first-found marked thread
> or to all marked threads. If we have a good reason to do the latter,
> I'm ok about it. Any idea?
Well, it would be more flexible if the signal were sent to all marked
threads, but I don't know if that constitutes a good enough reason to add
the extra complexity involved. Sometimes better is the enemy of good, and
in this case the patch you proposed should be good enough for any practical
case I can think of.
Naoya, Tony, thank you for taking the leadership on this issue and seeing
it through, and for the courtesy of keeping me in the loop!
Kamil
--
Kamil Iskra, PhD
Argonne National Laboratory, Mathematics and Computer Science Division
9700 South Cass Avenue, Building 240, Argonne, IL 60439, USA
phone: +1-630-252-7197 fax: +1-630-252-5986
next prev parent reply other threads:[~2014-05-30 19:52 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-20 17:35 [PATCH 0/2] Fix some machine check application recovery cases Tony Luck
2014-05-20 16:28 ` [PATCH 1/2] memory-failure: Send right signal code to correct thread Tony Luck
[not found] ` <1400608486-alyqz521@n-horiguchi@ah.jp.nec.com>
2014-05-20 20:56 ` Luck, Tony
2014-05-23 3:34 ` Chen, Gong
2014-05-23 16:48 ` Tony Luck
2014-05-27 16:16 ` Kamil Iskra
[not found] ` <5384d07e.4504e00a.2680.ffff8c31SMTPIN_ADDED_BROKEN@mx.google.com>
2014-05-27 22:53 ` Tony Luck
[not found] ` <53852abb.867ce00a.3cef.3c7eSMTPIN_ADDED_BROKEN@mx.google.com>
2014-05-28 5:09 ` Tony Luck
[not found] ` <53862f6c.91148c0a.5fb0.2d0cSMTPIN_ADDED_BROKEN@mx.google.com>
2014-05-28 22:00 ` [PATCH] mm/memory-failure.c: support dedicated thread to handle SIGBUS(BUS_MCEERR_AO) thread Tony Luck
[not found] ` <5386915f.4772e50a.0657.ffffcda4SMTPIN_ADDED_BROKEN@mx.google.com>
2014-05-29 17:03 ` Tony Luck
[not found] ` <1401327939-cvm7qh0m@n-horiguchi@ah.jp.nec.com>
2014-05-30 19:52 ` Kamil Iskra [this message]
2014-05-20 16:46 ` [PATCH 2/2] memory-failure: Don't let collect_procs() skip over processes for MF_ACTION_REQUIRED Tony Luck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140530195208.GB4067@mcs.anl.gov \
--to=iskra@mcs.anl.gov \
--cc=andi@firstfloor.org \
--cc=bp@suse.de \
--cc=gong.chen@linux.jf.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=n-horiguchi@ah.jp.nec.com \
--cc=tony.luck@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®