mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: emilgoode@gmail.com
Cc: Wei.Yang@windriver.com, peppe.cavallaro@st.com,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] stmmac: Remove spin_lock call in stmmac_get_pauseparam()
Date: Mon, 02 Jun 2014 10:38:34 -0700 (PDT)	[thread overview]
Message-ID: <20140602.103834.1994455666478487120.davem@davemloft.net> (raw)
In-Reply-To: <1401701450-1203-1-git-send-email-emilgoode@gmail.com>

From: Emil Goode <emilgoode@gmail.com>
Date: Mon,  2 Jun 2014 11:30:50 +0200

> The following patch removed unnecessary spin_lock/unlock calls
> in ethtool_ops callback functions. In the second and final version
> of the patch one spin_lock call was left behind.
> 
> commit cab6715c3e8029e98b0b5d4056ceda007c0f6380
> Author: Yang Wei <Wei.Yang@windriver.com>
> Date:   Sun May 25 09:53:44 2014 +0800
> 
>     net: driver: stmicro: Remove some useless the lock protection
> 
> This introduced the following sparse warning:
> 
> drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c:424:1: warning:
> 	context imbalance in 'stmmac_get_pauseparam' -
> 	different lock contexts for basic block
> 
> Signed-off-by: Emil Goode <emilgoode@gmail.com>

Good catch, applied, thanks Emil.

      reply	other threads:[~2014-06-02 17:38 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-02  9:30 Emil Goode
2014-06-02 17:38 ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140602.103834.1994455666478487120.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=Wei.Yang@windriver.com \
    --cc=emilgoode@gmail.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=peppe.cavallaro@st.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®